-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refresh mappings to latest editor's draft #937
feat: refresh mappings to latest editor's draft #937
Conversation
🦋 Changeset detectedLatest commit: 9eafad5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very much appreciated. I think there was a misunderstanding that tracking accname editors draft implies tracking editors draft of every other spec. The other ones should still be stable. Only accname is draft.
That's what we've been doing and I don't want to change it until there's a concrete reason not to.
Ah my bad! I’ll take a look next week at reverting back to "stable" specs (though this isn’t perhaps a clear definition, W3C works in a series drafts or recommendations, will use best effort unless you have particular preference on versions to use - even aria-query appears inconsistent on this A11yance/aria-query#498) for aria and aam (may mean a lot fewer changes) and will get round to ref’ing or raising issues for any of the inconsistencies I’ve found in appropriate places/repos. Thanks for the review 😊 |
ef26ed9
to
84f2cb7
Compare
Having some problems when update the wpt submodule:
For now reverting updating that submodule - where have indicated new WPT failures with comments there are no updates to those tests in latest WPT so think can separate doing that out independently (if happy with that)? |
This reverts commit 879d25d.
84f2cb7
to
014bfd0
Compare
@eps1lon think have resolved your comments - appreciate a re-review if / when have time. |
Refreshes the package's mappings for roles (and some other role adjacent mappings) to align with:
(Following clarification of intended version support in #936 and PR comments)
Notable changes:
Other notes:
a
,area
, andlink
implicit mapping, no other conditional implicit role mappings have been added. This means there are still outstanding edge-cases where the implicit role will be incorrect, e.g. the role forfooter
when not a child of abody
."none"
role as a synonym for the"presentation"
role #933, so the"none"
role has not been introduced here.