Bugfix/fix add asset

[YaroslavPodporinEqLab]

Summary by CodeRabbit

• New Features

  • Enhanced error handling for balance retrieval, allowing independent processing of multiple token addresses.
  • Improved rendering logic in the AddAsset component for a more intuitive user experience based on available assets.

• Bug Fixes

  • Resolved issues where the failure of one token balance retrieval would affect others.

• Chores

  • Updated pre-commit hook to lint all files in the project, improving overall code quality checks.

[coderabbitai]

Walkthrough

The changes involve updates to various components and hooks in the codebase, enhancing error handling in balance retrieval, modifying asset handling logic based on available assets, and adjusting the pre-commit linting strategy to apply to all files instead of only staged ones. These modifications aim to improve the robustness and clarity of the code while maintaining existing functionalities.

Changes

File	Change Summary
.husky/pre-commit	Changed linting command from yarn run lint:staged to yarn eslint ., modifying linting scope to all project files.
packages/app/src/entities/token/hooks/use-get-balance.ts	Enhanced error handling in useGetBalance function to allow independent balance retrieval for tokens, logging errors and returning default values as needed.
packages/app/src/features/liquidity-flow/components/add-asset/add-asset.tsx	Updated rendering logic in AddAsset component to depend on assetsInfo instead of excludedTokens, improving clarity.
packages/app/src/features/liquidity-flow/hooks/use-get-assets-info.ts	Added a blank line after variable declaration in useGetAssetsInfo, improving code formatting without affecting functionality.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant AddAsset
    participant useGetAssetsInfo
    
    User->>AddAsset: Request to add an asset
    AddAsset->>useGetAssetsInfo: Retrieve asset information
    useGetAssetsInfo-->>AddAsset: Return assetsInfo
    AddAsset->>User: Display AddAssetButton or AssetSelect based on assetsInfo

Loading

🐰 In the code, a hop and a skip,
Linting now takes a broader trip.
Balances fetched with care and grace,
Assets displayed in a clearer space.
With every change, we dance and cheer,
For a codebase bright and clear! 🥕

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between bdd8038 and 9d8a8ca.

Files selected for processing (4)

• .husky/pre-commit (1 hunks)
• packages/app/src/entities/token/hooks/use-get-balance.ts (1 hunks)
• packages/app/src/features/liquidity-flow/components/add-asset/add-asset.tsx (1 hunks)
• packages/app/src/features/liquidity-flow/hooks/use-get-assets-info.ts (1 hunks)

Files skipped from review due to trivial changes (1)

• packages/app/src/features/liquidity-flow/hooks/use-get-assets-info.ts

Additional comments not posted (6)

.husky/pre-commit (1)

4-4: Consider the performance impact of linting all files.

Changing the linting strategy to lint all files instead of only staged ones may lead to longer commit times. Ensure that this change is intentional and the performance impact is acceptable.

Verify if this change is necessary and if there are any performance concerns.

packages/app/src/features/liquidity-flow/components/add-asset/add-asset.tsx (3)

16-16: LGTM!

The rendering logic based on the length of assetsInfo is clear and intuitive.

The code changes are approved.

---

20-28: LGTM!

The rendering logic for multiple assets is clear and intuitive.

The code changes are approved.

---

30-30: LGTM!

The final return statement is clear and intuitive.

The code changes are approved.

packages/app/src/entities/token/hooks/use-get-balance.ts (2)

46-48: LGTM!

Using Promise.all to fetch balances for multiple token addresses is efficient.

The code changes are approved.

---

70-71: LGTM!

Setting the balance information and fetched status is correctly implemented.

The code changes are approved.