refactor(storage): cleanup heades table #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mirko-von-Leipzig
force-pushed
the
db_headers
branch
from
c02f331
to
ec2b38d
Compare
CHr15F0x
approved these changes
Jul 31, 2023
kkovaacs
reviewed
Aug 2, 2023
sergey-melnychuk
approved these changes
Aug 2, 2023
It was migrating instead of checking the current version.
Mirko-von-Leipzig
force-pushed
the
db_headers
branch
from
3a863ef
to
a704ff8
Compare
Co-authored-by: Krisztian Kovacs <krisztian@equilibrium.co> Review changes and fixes.
Mirko-von-Leipzig
force-pushed
the
db_headers
branch
from
a704ff8
to
e8dc9c8
Compare
|
I renamed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the headers table in the database, aligning it with p2p requirements.
p2p introduces requirements for headers to be a much more standalone concept e.g. the block hash should be calculated only from properties in the header. This PR adds the missing fields to storage, and also renames some things.
Actual changes to the headers table:
starknet_blockstoheadersrootcolumn renamed tostorage_commitmenttransaction_countandevent_countstate_commitmentwhich previously was calculated on demand@CHr15F0x I have no idea how to update the proptests for these new additions?
I would also appreciate thinking if I missed any locations which rely on this information? I have sync and p2p changed so I think its all.