refactor: Peers into PeerSet
#1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sistemd
force-pushed
the
sistemd/peers-refactor
branch
from
5fe7608
to
091a09a
Compare
sistemd
commented
Jan 31, 2024
crates/p2p/src/main_loop.rs
Outdated
Comment on lines
33
to
34
| // TODO What do we need this for? | ||
| pending_dials: HashMap<PeerId, EmptyResultSender>, |
There was a problem hiding this comment.
This currently seems unused. We're keeping track of pending dials, but we use this information for nothing.
@CHr15F0x Do you know what this is about? Can I remove this?
There was a problem hiding this comment.
Ah my bad, it's actually used to match dial responses with commands since dialing is asynchronous 🤦
Mirko-von-Leipzig
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the
Peerstype so it makes more sense. Make it so thatPeersis the single source of truth for our peers. Add the newusefulandevictedflags needed by #1711.