Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to the latest, simpler p2p spec #1729

Merged
merged 16 commits into from
Feb 14, 2024
Merged

update to the latest, simpler p2p spec #1729

merged 16 commits into from
Feb 14, 2024

Conversation

CHr15F0x
Copy link
Member

@CHr15F0x CHr15F0x commented Feb 2, 2024

Fixes: #1717

"Old" style p2p sync client removed along with the parser module. Delta is big because the changes in dtos are significant. Thus the capability to sync from other nodes is temporarily missing until streams are implemented for all protocols.

There's at least 3 things I'd like to do in followup PR-s that are missing here:

  • decrease the message size limit on the wire to 4MiB for classes and 1MiB otherwise,
  • compute the address field of Deploy transactions,
  • use fluke channel in sync handlers to pass items as they are read without intermediate collection into Vec.

@CHr15F0x CHr15F0x force-pushed the chris/simpler-p2p-spec branch 8 times, most recently from e7439cf to a8581f8 Compare February 9, 2024 16:01
@CHr15F0x CHr15F0x force-pushed the chris/simpler-p2p-spec branch 18 times, most recently from 4b6a8c0 to 6f264cc Compare February 13, 2024 08:43
@CHr15F0x CHr15F0x marked this pull request as ready for review February 13, 2024 15:57
@CHr15F0x CHr15F0x requested a review from a team as a code owner February 13, 2024 15:57
crates/gateway-types/src/reply.rs Show resolved Hide resolved
@CHr15F0x CHr15F0x merged commit ca33e54 into main Feb 14, 2024
7 checks passed
@CHr15F0x CHr15F0x deleted the chris/simpler-p2p-spec branch February 14, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

p2p: align with the latest, simplified spec
2 participants