-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to the latest, simpler p2p spec #1729
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHr15F0x
force-pushed
the
chris/simpler-p2p-spec
branch
8 times, most recently
from
February 9, 2024 16:01
e7439cf
to
a8581f8
Compare
CHr15F0x
force-pushed
the
chris/simpler-p2p-spec
branch
18 times, most recently
from
February 13, 2024 08:43
4b6a8c0
to
6f264cc
Compare
CHr15F0x
force-pushed
the
chris/simpler-p2p-spec
branch
from
February 13, 2024 11:26
6f264cc
to
c123e1f
Compare
CHr15F0x
force-pushed
the
chris/simpler-p2p-spec
branch
from
February 13, 2024 12:36
c123e1f
to
aaca861
Compare
sistemd
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1717
"Old" style p2p sync client removed along with the parser module. Delta is big because the changes in dtos are significant. Thus the capability to sync from other nodes is temporarily missing until streams are implemented for all protocols.
There's at least 3 things I'd like to do in followup PR-s that are missing here: