Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(p2p): properly pass the ip_whitelist flag #1744

Merged
merged 1 commit into from
Feb 6, 2024
Merged

fix(p2p): properly pass the ip_whitelist flag #1744

merged 1 commit into from
Feb 6, 2024

Conversation

sistemd
Copy link
Contributor

@sistemd sistemd commented Feb 5, 2024

Properly pass the ip_whitelist flag from CLI into p2p. Remove Config::new since the idea is that Config is just a data struct that the client should provide values for.

@sistemd sistemd marked this pull request as ready for review February 5, 2024 14:44
@sistemd sistemd requested a review from a team as a code owner February 5, 2024 14:44
@sistemd sistemd merged commit 287b56e into main Feb 6, 2024
7 checks passed
@sistemd sistemd deleted the sistemd/ip_whitelist branch February 6, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mirko-von-Leipzig Mirko-von-Leipzig Mirko-von-Leipzig approved these changes

@CHr15F0x CHr15F0x CHr15F0x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sistemd @CHr15F0x @Mirko-von-Leipzig