feat(p2p): outbound peer eviction #1748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sistemd
force-pushed
the
sistemd/outbound-eviction
branch
from
80fc3b8
to
628e733
Compare
sistemd
force-pushed
the
sistemd/outbound-eviction
branch
from
628e733
to
b1abfe1
Compare
Mirko-von-Leipzig
approved these changes
Feb 9, 2024
Comment on lines
+502
to
+507
| let (peer_id, _) = candidates.pop().ok_or_else(|| { | ||
| tracing::debug!("Outbound peer limit reached, but no peers could be evicted"); | ||
| ConnectionDenied::new(anyhow!( | ||
| "outbound peer limit reached and no peers could be evicted" | ||
| )) | ||
| })?; |
There was a problem hiding this comment.
Can also be done using the let Some(_) = .. else { .. }; syntax which saves a closure and highlights the control flow 🤷
CHr15F0x
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evict outbound peers for which
useful = falsewhen a new outbound connection is attempted. Did this first because it's simpler than inbound peer eviction.Part of #1711.