Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(checkpoint/state_diff): merge trie updates #2333

Merged
merged 4 commits into from
Oct 28, 2024
Merged

feat(checkpoint/state_diff): merge trie updates #2333

merged 4 commits into from
Oct 28, 2024

Conversation

CHr15F0x
Copy link
Member

@CHr15F0x CHr15F0x commented Oct 23, 2024 •
edited
Loading

The *Ref<'_> structs were necessary to achieve an acceptable equilibrium:

  • use the same impl of applying state update for both single- and multi-block state updates,
  • avoid generics explosion when trying to use [Parallel]Iterator trying to achieve above (with which I eventually failed anyway),
  • keep number of allocations low.

@CHr15F0x CHr15F0x marked this pull request as ready for review October 23, 2024 11:35
@CHr15F0x CHr15F0x requested a review from a team as a code owner October 23, 2024 11:35
kkovaacs
kkovaacs approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@kkovaacs kkovaacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

crates/p2p/src/builder.rs Outdated Show resolved Hide resolved
@CHr15F0x
Copy link
Member Author

This PR also fixes the client side of #2334

@CHr15F0x CHr15F0x merged commit ae0f5e0 into main Oct 28, 2024
7 checks passed
@CHr15F0x CHr15F0x deleted the chris/faster-state-updates-2 branch October 28, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sistemd sistemd sistemd approved these changes

@kkovaacs kkovaacs kkovaacs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CHr15F0x @kkovaacs @sistemd