New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard check onEscape - Popover #1529

Closed

pomfrida opened this issue Aug 25, 2021 · 0 comments · Fixed by #1534

Assignees

Labels

🐛 bug core-react

Contributor

pomfrida commented Aug 25, 2021

From Slack:

After the popover was upgraded, I was not aware of the escape behaviour, until an e2e test failed for no sane reason. Pressing escape in our app now opens a ton of popovers, because onClose was implemented as a toggle. Since this behaviour is global, could it be guarded by an if open check? I guess the intention is to close all popover on escape press.

pomfrida added core-react 🐛 bug labels

pomfrida self-assigned this

pomfrida mentioned this issue

🐛 Popover guard for onEscape #1534

Merged

pomfrida closed this as completed in #1534

This was referenced Sep 29, 2021

Release next version of packages #1582

Closed

Release core-react@0.14.0 #1584

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment