Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Popover guard for onEscape #1534

Merged
merged 1 commit into from
Sep 1, 2021
Merged

🐛 Popover guard for onEscape #1534

merged 1 commit into from
Sep 1, 2021

Conversation

pomfrida
Copy link
Contributor

@pomfrida pomfrida commented Sep 1, 2021

Resolves #1529

mimarz
mimarz approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pomfrida pomfrida merged commit 3849479 into equinor:develop Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz mimarz approved these changes

@vnys vnys Awaiting requested review from vnys vnys is a code owner

@wenche wenche Awaiting requested review from wenche

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Guard check onEscape - Popover
2 participants
@pomfrida @mimarz