Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next and previous icon button for navigation in Tabs #1650

Closed
herda1 opened this issue Oct 22, 2021 · 6 comments · Fixed by #1962
Closed

Next and previous icon button for navigation in Tabs #1650

herda1 opened this issue Oct 22, 2021 · 6 comments · Fixed by #1962
Assignees
Labels

Comments

@herda1
Copy link

herda1 commented Oct 22, 2021

Describe the bug

Scrolling of tabs horizontally does not have 'next and previous icon button for navigation' in navigation tabs as described in EDS components.

image (20)

Steps to reproduce the bug

  1. Go EDS storybook
  2. Go to Components -> Tabs -> States
  3. Reduced the browser width
  4. Try to scroll
  5. Check that the clickable next and previous icon buttons for navigation are missing

CPT2110221338-375x732
.

Expected behavior

  • Add button (chevron) to scroll right or left when applicable
  • Horizontal scrolling as clicking the button (chevron)
  • Fade overlay to indicate more tabs

An example of tabs with the expected behavior is shown below:

image

Additional context

https://codesandbox.io/s/small-bash-qs5he?file=/src/App.tsx

@herda1 herda1 added the 🐛 bug Something isn't working label Oct 22, 2021
@mimarz
Copy link
Contributor

mimarz commented Oct 27, 2021

Awesome! Things are abit busy with EDC preperations now, but we'll bring it up for planning next time around :)

Edit: Added "feature request" label as its a "missing" feature.

@akvam akvam removed the 🐛 bug Something isn't working label Nov 24, 2021
@mimarz mimarz added the ✨ enhancement Enhancements for our existing components label Nov 24, 2021
@mimarz mimarz added the core-react eds-core-react label Dec 13, 2021
@nilsml
Copy link
Contributor

nilsml commented Jan 3, 2022

I have been told that two teams are waiting for this fix. We should discuss this is tomorrow's planning meeting.

@BirteThornquist
Copy link
Contributor

Decided in todays planning meeting to find a way to help them so they can implement a previous/next chevron in their tab menu. We will not add the chevrons to the tab component in EDS. We will however look into how we can create a responsive tab menu. This will be handled in a separate issue #1889

@akvam
Copy link

akvam commented Jan 19, 2022

To do:

  • Help team with the technical solution
  • Update the documentation

@vnys
Copy link
Member

vnys commented Jan 26, 2022

As I wrote in the pr, Google is investigating how to solve the issue of too many tabs to fit in the tab strip. In Chrome right now you can test out different options and give them feedback.

@vnys
Copy link
Member

vnys commented Jan 31, 2022

@oddvernes oddvernes self-assigned this Feb 3, 2022
@vnys vnys removed their assignment Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
7 participants