-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Enable Tabs horizontal overflow #1962
Conversation
21950b9
to
da83bb4
Compare
da83bb4
to
86fcbc0
Compare
86fcbc0
to
22e91c5
Compare
Looks good code wise, there is a lot to unwrap 😅 I think the animation looks fine, but I think we need to have a review with @equinor/eds-ux on the behaviour and design (with the scrollbar) and such. Speaking of scrollbar, maybe we should just design our own? The placement if feel messes visually with the "underline" we have on each Tab. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed by making outline-offset negative outline-width. I expect this to be further improved by making focus ring 2px wide everywhere we use dashed :focus-visible |
Approved from design side. Great work :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
resolves #1650
scrollable
prop to addoverflow-x: auto
on Tabs.List (default itsoverflow-x: hidden
scroll-snap
properties to Tabs.List and tabs.Tab, so that next/prev buttons can be more easily implemented by just usingelement.scrollTo
.scrollable
on an overflowing Tabs list.Debatable decitions:
scroll-behavior: smooth
on the tabslist (unless user haveprefers-reduced-motion
) so scrolling is animated. I think it makes it easier keep track of the context-change visually, but i realize there are no animations otherwise in eds.scrollable
is set) on touch devices, as i think it gets in the way of swipe gesture and reduces the user experience.Issues with mac (not present on windows 10) that I am currently trying to fix:
chrome/firefox:
Safari: