Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix focus ring on components #1705

Closed
mimarz opened this issue Nov 16, 2021 · 2 comments
Closed

Fix focus ring on components #1705

mimarz opened this issue Nov 16, 2021 · 2 comments
Assignees
Labels
🐛 bug Something isn't working 🕵️ investigate

Comments

@mimarz
Copy link
Contributor

mimarz commented Nov 16, 2021

Chromium was recently updated for more complex outlines. https://chromium.googlesource.com/chromium/src/+/77a5954e1f52f5d9bbb9808e490fc9ae9233ec2d

One improvement was that border-radius now works on outline. Since this change, we might need to adjust the outline offset on some of our components (and Figma?) Button focus frame is now very hard to see due to short offset.

Edit:
image
image

@oddvernes
Copy link
Collaborator

I feel like 1px thickness of this is not helping, I have to lean in to see it on my laptop monitor

@mimarz mimarz changed the title Focus frame offset componenets Fix focus frame on components Nov 24, 2021
@vnys vnys changed the title Fix focus frame on components Fix focus ring on components Nov 25, 2021
@vnys
Copy link
Member

vnys commented Nov 29, 2021

Bente and I concluded that the problem is bigger than just fixing the focus-ring on the button-component, as there are inconsistencies with how we indicate focus across components. This is not critical, so I’ve made a new issue – “Make focus-indicators more uniform across components” (#1733) – and added it to the “Conforming Components” epic (#1598).

@vnys vnys closed this as completed Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🕵️ investigate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants