-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make focus-indicators more uniform across components #1733
Comments
We've had long discussions about this all year, in short we've landed on these approaches so far
Focus frame being a dotted line, with With the changes to rendering focus, we've noticed that the outline offset became to small & outline line to thin. |
the focus frame currently is 1px dashed. Just changing it to 2px makes a big difference, and then maybe increase the offset from 2px to 3px |
Let’s discuss this issue in the backlog meeting on Wednesday |
After discussion with @lucasveil and @mimarz we have decided to decouple the focus-width from figma and instead hard code it in the figma broker to 2px. I will go over each component with |
Components with focus-visible (that uses dashed outline) have been updated to fetch outline-width from token, and token have been updated to 2px, but for now this is hardcoded in figma-broker. Radio/Checkbox: offset reduced by 1px so focus-ring doesn't touch label, table borders: Button/Chip/Slider: increase offset by 1px to make where focus is it easier to spot when scanning: Ghost_icon button: offset -2px so it is inset to clickbounds and fit inside table |
Both clickbounds and focus-indicators vary greatly across components, as can be seen in the screenshot. Most components have dotted outlines, but not all – and the spacing between the components and the focus-indicators are inconsistent.
The text was updated successfully, but these errors were encountered: