Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data-grid: align selection state props with react table #3461

Closed
oddvernes opened this issue May 23, 2024 · 0 comments · Fixed by #3456
Closed

Data-grid: align selection state props with react table #3461

oddvernes opened this issue May 23, 2024 · 0 comments · Fixed by #3456

Comments

@oddvernes
Copy link
Collaborator

I am creating this ticket to document this pr which will introduce some breaking changes o Data-grid:

This pull request does several improvements regarding aligning the react-table api.

  • Warn developer in developer environment when using deprecated props.
  • Rename selectedRows to rowSelectionState and deprecated selectedRows.
  • Rename rowSelection to enableRowSelection and deprecated rowSelection.
  • Add onRowClick and onCellClick handlers as props.
  • Rename multiRowSelection to `enableMultiRowSelection. No deprecation since it is not released yet.
  • Add example to storybook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Align selection state props with react table equinor/design-system
1 participant
@oddvernes