Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Align selection state props with react table #3456

Merged
merged 4 commits into from
May 23, 2024
Merged

🐛 Align selection state props with react table #3456

merged 4 commits into from
May 23, 2024

Conversation

magnh
Copy link
Contributor

@magnh magnh commented May 22, 2024 •
edited by oddvernes
Loading

What does this pull request change?

This pull request does several improvements regarding aligning the react-table api.

  • Warn developer in developer environment when using deprecated props.
  • Rename selectedRows to rowSelectionState and deprecated selectedRows.
  • Rename rowSelection to enableRowSelection and deprecated rowSelection.
  • Add onRowClick and onCellClick handlers as props.
  • Rename multiRowSelection to `enableMultiRowSelection. No deprecation since it is not released yet.
  • Add example to storybook
    image

resolves #3461

@magnh magnh self-assigned this May 22, 2024
@magnh magnh requested a review from yusijs May 22, 2024 12:24
yusijs
yusijs requested changes May 22, 2024
View reviewed changes
packages/eds-data-grid-react/src/EdsDataGrid.tsx Outdated Show resolved Hide resolved
packages/eds-data-grid-react/src/EdsDataGrid.tsx Outdated Show resolved Hide resolved
yusijs
yusijs approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@yusijs yusijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusijs yusijs marked this pull request as ready for review May 22, 2024 12:51
oddvernes
oddvernes approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@oddvernes oddvernes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just pushed a fix for a wrong token usage, but otherwise LGTM!

@oddvernes oddvernes mentioned this pull request May 23, 2024
Closed
@magnh magnh changed the title fix: align selection state props with react table 🐛 Align selection state props with react table May 23, 2024
@magnh magnh merged commit a03050c into develop May 23, 2024
6 checks passed
@magnh magnh deleted the fix/table-select branch May 23, 2024 12:55
@mariush2 mariush2 mentioned this pull request Aug 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yusijs yusijs yusijs approved these changes

@oddvernes oddvernes oddvernes approved these changes

@vnys vnys Awaiting requested review from vnys vnys is a code owner

@torleifhalseth torleifhalseth Awaiting requested review from torleifhalseth torleifhalseth is a code owner

Assignees

@magnh magnh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data-grid: align selection state props with react table
3 participants
@magnh @oddvernes @yusijs