Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BannerAction doesn't applies CSS with the style prop #478

Closed
wenche opened this issue Aug 6, 2020 · 0 comments · Fixed by #641
Closed

BannerAction doesn't applies CSS with the style prop #478

wenche opened this issue Aug 6, 2020 · 0 comments · Fixed by #641
Assignees
@SvSven
Labels
🐛 bug Something isn't working core-react eds-core-react good first issue
Milestone
Hacktober Festivus 🎃

Comments

@wenche
Copy link
Contributor

wenche commented Aug 6, 2020

Describe the bug

The BannerAction component is missing the {...props} on the rendered element. Inline styles with prop style={{}} will not have affect (and other props as well ofc)

Solution: Add props spread
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SvSven SvSven

Labels
🐛 bug Something isn't working core-react eds-core-react good first issue
Projects
None yet
Milestone
Hacktober Festivus 🎃
Development

Successfully merging a pull request may close this issue.

🐛 fix missing props spread on BannerActions
3 participants
@wenche @vnys @SvSven