Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release eds-core-react@0.7.0 #912

Merged
merged 7 commits into from
Nov 26, 2020
Merged

Release eds-core-react@0.7.0 #912

merged 7 commits into from
Nov 26, 2020

Conversation

pomfrida
Copy link
Contributor

@pomfrida pomfrida commented Nov 24, 2020 •
edited
Loading

[0.7.0] - 2020-11-26

Added ✨

Fixed 🐛

  • Added a guard clause to handle null values for Accordion children (#688)
  • CardMedia spacing bug (#603)
  • Added props spread to BannerAction (#478)
  • Pagination bug (#647)
  • Bundle improvements (#627)
  • Cleaned up leaking devDependencies (#862)
  • Hide Tooltip when title is empty (#920)

Changed 📓

  • Updated z-index values for correct layering of the components (#872)
  • Changed licence from GNU AGPL to MIT (#852)
  • Clean up use of spacings in Card (#717)
  • Changed module types for better support with commonjs and esm. Using the <some-eds-npm-package>/commonjs path on packages should no longer be needed and will be deprecated in the future (#887)
  • Removed unused dependencies (#870)
  • Cleaning and remodelling core-react for the future 💅 (#887)

Resolves #907

@pomfrida
Copy link
Contributor Author

Ignored all Typescript related issues and bugfixes in this release, as they all are under the Typescript Milestone

Unsure if to include these issues as well:

@pomfrida pomfrida self-assigned this Nov 24, 2020
@pomfrida pomfrida added npm core-react eds-core-react labels Nov 24, 2020
@mimarz
Copy link
Contributor

mimarz commented Nov 25, 2020 •
edited
Loading

Suggest we keep these, and suggested description text along with them

We will also have to update the readme with the removal of /commonjs path in the future

@pomfrida pomfrida changed the title [WIP] Release eds-core-react@? [WIP] Release eds-core-react@0.7.0 Nov 25, 2020
@pomfrida pomfrida changed the title [WIP] Release eds-core-react@0.7.0 Release eds-core-react@0.7.0 Nov 26, 2020
@pomfrida pomfrida marked this pull request as ready for review November 26, 2020 08:38
@mimarz mimarz mentioned this pull request Nov 26, 2020
Merged
vnys
vnys requested changes Nov 26, 2020
View reviewed changes
Copy link
Member

@vnys vnys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on potential changes, the most important one is the Housekeeping heading, the rest are not that important.

libraries/core-react/CHANGELOG.md Outdated Show resolved Hide resolved
libraries/core-react/CHANGELOG.md Outdated Show resolved Hide resolved
libraries/core-react/CHANGELOG.md Outdated Show resolved Hide resolved
libraries/core-react/CHANGELOG.md Outdated Show resolved Hide resolved
@pomfrida pomfrida requested a review from vnys November 26, 2020 09:38
vnys
vnys approved these changes Nov 26, 2020
View reviewed changes
Copy link
Member

@vnys vnys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 👍

@pomfrida pomfrida merged commit 5b2047b into equinor:develop Nov 26, 2020
@pomfrida pomfrida deleted the ts-release branch November 26, 2020 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vnys vnys vnys approved these changes

@mimarz mimarz Awaiting requested review from mimarz

@wenche wenche Awaiting requested review from wenche

Assignees

@pomfrida pomfrida

Labels
core-react eds-core-react
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create pre-release for core-react
3 participants
@pomfrida @mimarz @vnys