Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create React Select component using native Select #509

Closed
mimarz opened this issue Aug 24, 2020 · 4 comments
Closed

Create React Select component using native Select #509

mimarz opened this issue Aug 24, 2020 · 4 comments
Assignees
@wenche
Labels
core-react eds-core-react 🔨 technical Technical debt and similar
Milestone
EDS 2020

Comments

@mimarz
Copy link
Contributor

mimarz commented Aug 24, 2020 •
edited by wenche
Loading

Anita Update 02.12.2020
This US has high priority. Not sure why it is on the low pri. milestone.
Spike US can be done first, if it is needed.

Create React component for Select. Consider using https://react-select.com/ or other librariers due to complexity of component
@mimarz mimarz added the core-react eds-core-react label Aug 24, 2020
@mimarz mimarz added this to the EDS Core React: Low priority milestone Aug 24, 2020
@mimarz mimarz mentioned this issue Aug 25, 2020
Closed
@mimarz mimarz changed the title Create React "Select" component Create React Select component Oct 30, 2020
@akvam akvam added High Priority 🔨 technical Technical debt and similar labels Nov 3, 2020
@mimarz mimarz mentioned this issue Nov 4, 2020
Closed
2 tasks
@mimarz
Copy link
Contributor Author

mimarz commented Nov 4, 2020

blocked by #655

@mimarz mimarz added the blocked This issue is blocked by another issue label Nov 4, 2020
@wenche
Copy link
Contributor

wenche commented Nov 13, 2020

We have created a discussion at Github

@wenche
Copy link
Contributor

wenche commented Nov 16, 2020

We decided to split this task:

  1. Native select (native version looking as much like the design as possible, but not 100% due to browser constraints)
  2. Select (styled version like the Figma design)
  3. Advanced version with some sort of search

@wenche wenche mentioned this issue Nov 16, 2020
Merged
@vnys vnys assigned wenche and unassigned pomfrida Nov 17, 2020
@wenche
Copy link
Contributor

wenche commented Nov 19, 2020

To clarify this split and to avoid this issue to be around until forever and a day, I create separate issues for the more complex variants of select

@wenche wenche changed the title Create React Select component Create React Select component using native Select Nov 19, 2020
@wenche wenche removed High Priority blocked This issue is blocked by another issue labels Nov 19, 2020
@wenche wenche closed this as completed Nov 19, 2020
@pomfrida pomfrida mentioned this issue Nov 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wenche wenche

Labels
core-react eds-core-react 🔨 technical Technical debt and similar
Projects
None yet
Milestone
EDS 2020
Development

No branches or pull requests
4 participants
@mimarz @wenche @akvam @pomfrida