Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwanted hover-effect on icons wrapped in ghost button #987

Closed
ErlendLygre opened this issue Dec 18, 2020 · 0 comments · Fixed by #988
Closed

Unwanted hover-effect on icons wrapped in ghost button #987

ErlendLygre opened this issue Dec 18, 2020 · 0 comments · Fixed by #988
Assignees
Labels
🐛 bug Something isn't working

Comments

@ErlendLygre
Copy link

Describe the bug

Hover state stays visible on ghost buttons after user has tapped on mobile

Steps to reproduce the bug

  1. Go to https://eds-storybook-react.azurewebsites.net/?path=/docs/components-selection-controls-checkbox--default
  2. Change to "toggle device toolbar" in chrome inspect mode. Select any phone
  3. Press the checkbox and remove "finger" from device,

Expected behavior

A ripple effect or no effect at all when pressing the checkbox, such as here https://material-ui.com/components/checkboxes/

Specifications

  • Version:
  • Browser:
  • OS:

Additional context

Add any other context or screenshots about the bug.

@ErlendLygre ErlendLygre added the 🐛 bug Something isn't working label Dec 18, 2020
@pomfrida pomfrida linked a pull request Jan 4, 2021 that will close this issue
@pomfrida pomfrida self-assigned this Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants