Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Stuck hover effects on touch devices #988

Merged
merged 2 commits into from
Jan 6, 2021
Merged

🐛 Stuck hover effects on touch devices #988

merged 2 commits into from
Jan 6, 2021

Conversation

pomfrida
Copy link
Contributor

@pomfrida pomfrida commented Jan 4, 2021

Solves #987

Using CSS media query approach to check if device has a mouse before applying hover styles

@pomfrida pomfrida self-assigned this Jan 4, 2021
@pomfrida pomfrida linked an issue Jan 4, 2021 that may be closed by this pull request
Unwanted hover-effect on icons wrapped in ghost button #987
Closed
@pomfrida pomfrida changed the title 🐛 [WIP] Stuck hover effects on touch devices 🐛 Stuck hover effects on touch devices Jan 4, 2021
@pomfrida pomfrida marked this pull request as ready for review January 4, 2021 10:53
wenche
wenche reviewed Jan 4, 2021
View reviewed changes
Copy link
Contributor

@wenche wenche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Lot's of fancy things one could do if IE is not an issue :)

@pomfrida pomfrida merged commit abfb578 into equinor:develop Jan 6, 2021
@pomfrida pomfrida deleted the checkbox-mobile-hover branch January 6, 2021 08:33
@pomfrida pomfrida mentioned this pull request Sep 29, 2021
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenche wenche wenche approved these changes

@vnys vnys Awaiting requested review from vnys vnys is a code owner

Assignees

@pomfrida pomfrida

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unwanted hover-effect on icons wrapped in ghost button
2 participants
@pomfrida @wenche