Fix AccordionHeader toggleExpanded #1121
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem:
AccordionItem shadows external toggleExpanded. The internal and external props are mixed.
A common use case is to defer render of components that are not visible to the user. I many of the inhouse application do have a lot of data and hidden components may be expensive to render.
solution:
add a new onToggle prop to support toggleExpanded when it's wrapped in AccordionItem.
#1120