Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Tooltip story #1181

Merged
merged 5 commits into from
Mar 29, 2021
Merged

Update Tooltip story #1181

merged 5 commits into from
Mar 29, 2021

Conversation

pomfrida
Copy link
Contributor

Story fixed so it matches the guidelines, resolves #1174
Also added delay on the examples, resolves #1154

mimarz
mimarz suggested changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest changing the to using the data property (way 2) instead of nameand Icon.add, just to make it clear for users that it comes from somewhere else.

libraries/core-react/stories/components/Tooltip.stories.tsx Show resolved Hide resolved
@pomfrida pomfrida requested a review from mimarz March 25, 2021 13:42
mimarz
mimarz suggested changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see that you changed how the icons are used?

@pomfrida pomfrida requested a review from mimarz March 26, 2021 15:18
mimarz
mimarz approved these changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mimarz mimarz merged commit 4217443 into equinor:develop Mar 29, 2021
@pomfrida pomfrida deleted the tooltip-story branch June 9, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz mimarz approved these changes

@vnys vnys Awaiting requested review from vnys vnys is a code owner

@wenche wenche Awaiting requested review from wenche

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify tooltip examples Show tooltips with a delay
2 participants
@pomfrida @mimarz