Update Menu hover state #1410
Merged
Update Menu hover state #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But does not work on complex menu
But not ideal, width still auto adjusts on complex menu
|
So this update ended up a bit more complex than expected. We have auto width menus so the width gets auto adjusted when text becomes bold on hover. I added a hack to avoid the auto width adjustment but this only works for simple menus (when there's only one child and the child is a string). Example of menu working as expected: Example of complex menu not working ideal (as there's more than one child and combination of different types): |
for complex menus
Testing with same as menu title color I think it looks better
|
Blocked by #1426 |
Also added radius for first and last menu list item
|
Changes done as suggested in #1426 and ready for review now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1363