Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stacking Snackbar #1485

Merged
merged 3 commits into from
Jul 15, 2021
Merged

Stacking Snackbar #1485

merged 3 commits into from
Jul 15, 2021

Conversation

pomfrida
Copy link
Contributor

@pomfrida pomfrida commented Jul 13, 2021 •
edited
Loading

Resolves #1173, resolves #1172

@pomfrida pomfrida self-assigned this Jul 13, 2021
@pomfrida pomfrida changed the title [WIP] Stacking Snackbar Stacking Snackbar Jul 13, 2021
@pomfrida pomfrida marked this pull request as ready for review July 13, 2021 14:56
mimarz
mimarz suggested changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftAlignFrom does not seem to when using pixels vales aswell as left spacing not being applied?

image

A follow-up after this PR would also be #1486

@pomfrida pomfrida requested a review from mimarz July 15, 2021 08:18
@pomfrida
Copy link
Contributor Author

This PR also fixes #1172

mimarz
mimarz approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🍭

@pomfrida pomfrida merged commit dadd85b into equinor:develop Jul 15, 2021
@pomfrida pomfrida deleted the snackbar branch July 15, 2021 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz mimarz approved these changes

@vnys vnys Awaiting requested review from vnys vnys is a code owner

@wenche wenche Awaiting requested review from wenche

Assignees

@pomfrida pomfrida

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve snackbars stacking context Improve snackbar centering
2 participants
@pomfrida @mimarz