Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝♿️ Progress a11y #2182

Merged
merged 11 commits into from
Jun 1, 2022
Merged

Conversation

oddvernes
Copy link
Collaborator

@oddvernes oddvernes commented May 3, 2022

resolves #2020

I added an invisible output element to linear and circular determinate progress so screenreaders should read out new values if it is inside a container with aria-live (I could not get it to read out aria-valuenow, I think maybe the element needs to be made focusable and be in focus for that to work). The output value is limited to 25/50/75/100% to limit readouts (its possible setting aria-live to assertive instead of polite also helps with this, its hard to tell with this behaving different in different browsers)

The other issues about aria-describedby/aria-label is already supported by ...rest going to the element with role="progressbar" so I added stories to storybook showing this

@oddvernes oddvernes self-assigned this May 4, 2022
@oddvernes oddvernes marked this pull request as ready for review May 4, 2022 11:59
@oddvernes oddvernes removed their assignment May 5, 2022
@mimarz
Copy link
Contributor

mimarz commented May 10, 2022

When testing the accessibility story for linear and circular the voice over is stuck on "loading 0%" 🤔

@oddvernes
Copy link
Collaborator Author

When testing the accessibility story for linear and circular the voice over is stuck on "loading 0%" 🤔

Well first of all I am going to rebase on develop, stand by

@oddvernes oddvernes force-pushed the enhancement/OOV-2020-progress-a11y branch from 9efcb79 to 5b96f2f Compare May 10, 2022 14:00
@oddvernes
Copy link
Collaborator Author

Hmm it looks like the mac voiceover reads out a bunch of stuff that is not read on windows. It is not supposed to read loading percentages for indeterminate loader. I need to investigate more on mac. The determinate loader demos on circular and linear works as it is supposed

@oddvernes
Copy link
Collaborator Author

Fixed mac issue by not including output element for indeterminate

Copy link
Contributor

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VoiceOver on Mac does not seem to read out loading states for linear and star accessibility stories... 🤔

@oddvernes
Copy link
Collaborator Author

It was due to aria-busy. I removed it and made aria-live assertive as well so the loading readout interrupts the long winded readout of the button context

@oddvernes oddvernes requested review from mimarz and removed request for laliq May 23, 2022 13:21
Copy link
Contributor

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now! ♿👍

@oddvernes oddvernes merged commit 6faf98a into develop Jun 1, 2022
@oddvernes oddvernes deleted the enhancement/OOV-2020-progress-a11y branch June 1, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aria-label for Progress
2 participants