-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝♿️ Progress a11y #2182
📝♿️ Progress a11y #2182
Conversation
When testing the accessibility story for linear and circular the voice over is stuck on "loading 0%" 🤔 |
Well first of all I am going to rebase on develop, stand by |
9efcb79
to
5b96f2f
Compare
Hmm it looks like the mac voiceover reads out a bunch of stuff that is not read on windows. It is not supposed to read loading percentages for indeterminate loader. I need to investigate more on mac. The determinate loader demos on circular and linear works as it is supposed |
Fixed mac issue by not including output element for indeterminate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VoiceOver on Mac does not seem to read out loading states for linear and star accessibility stories... 🤔
It was due to aria-busy. I removed it and made aria-live assertive as well so the loading readout interrupts the long winded readout of the button context |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works now! ♿👍
resolves #2020
I added an invisible
output
element tolinear
andcircular
determinate progress so screenreaders should read out new values if it is inside a container witharia-live
(I could not get it to read outaria-valuenow
, I think maybe the element needs to be made focusable and be in focus for that to work). The output value is limited to 25/50/75/100% to limit readouts (its possible setting aria-live to assertive instead of polite also helps with this, its hard to tell with this behaving different in different browsers)The other issues about aria-describedby/aria-label is already supported by
...rest
going to the element with role="progressbar" so I added stories to storybook showing this