Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 typographyTemplate in Tab #2316

Merged
merged 4 commits into from
Jun 17, 2022
Merged

Conversation

martalalik
Copy link
Contributor

Resolves #2283

@martalalik martalalik marked this pull request as ready for review June 16, 2022 09:14
Copy link
Contributor

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just some suggested cleaning up

@@ -28,6 +29,7 @@ const StyledTab = styled.button.attrs<TabProps>(
font-size: 1rem;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest cleaning up the css thats now replaced by typography template. Font-family, font-size.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 😊

@martalalik martalalik force-pushed the bug/ML-2283-tabs-canvas-typography branch from b2f62c3 to e145c0f Compare June 16, 2022 11:22
@martalalik martalalik requested a review from mimarz June 16, 2022 11:30
Copy link
Contributor

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@martalalik martalalik merged commit 303eebe into develop Jun 17, 2022
@martalalik martalalik deleted the bug/ML-2283-tabs-canvas-typography branch June 17, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong/missing body/font-family reference for tabs
2 participants