Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 Add FloatingOverlay to Scrim #2513

Merged
merged 2 commits into from
Sep 22, 2022
Merged

🎨 Add FloatingOverlay to Scrim #2513

merged 2 commits into from
Sep 22, 2022

Conversation

martalalik
Copy link
Contributor

Resolves #2470

oddvernes
oddvernes approved these changes Sep 22, 2022
View reviewed changes
Copy link
Collaborator

@oddvernes oddvernes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This adds padding to body when there is a scrollbar so we don't get content jump as it opens, and should also work better at preventing scrolling on ios

@martalalik martalalik merged commit e262a6d into develop Sep 22, 2022
@martalalik martalalik deleted the enh/ML-2470-scrim-floating-ui branch September 22, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oddvernes oddvernes oddvernes approved these changes

@mimarz mimarz Awaiting requested review from mimarz

@vnys vnys Awaiting requested review from vnys vnys is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use FloatingOverlay from floating-ui in Scrim
2 participants
@martalalik @oddvernes