Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Breadcrumb/Typography: use transient props #2542

Merged
merged 2 commits into from
Oct 4, 2022
Merged

🐛 Breadcrumb/Typography: use transient props #2542

merged 2 commits into from
Oct 4, 2022

Conversation

oddvernes
Copy link
Collaborator

resolves #2538

Now casting breadcrumb as={Link} from react router will not throw warnings about maxWidth being applied to a dom element

mimarz
mimarz approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@oddvernes oddvernes merged commit 1563810 into develop Oct 4, 2022
@oddvernes oddvernes deleted the OOVE/2538-overridable-breadcrumb-error branch October 4, 2022 13:45
@mimarz mimarz mentioned this pull request Oct 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz mimarz approved these changes

@vnys vnys Awaiting requested review from vnys vnys is a code owner

@martalalik martalalik Awaiting requested review from martalalik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breadcrumbs: fix polymorphic issue
2 participants
@oddvernes @mimarz