Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Autocomplete: Support for toggling if input is cleared on selection #2545

Merged
merged 3 commits into from
Oct 5, 2022
Merged

✨ Autocomplete: Support for toggling if input is cleared on selection #2545

merged 3 commits into from
Oct 5, 2022

Conversation

mimarz
Copy link
Contributor

@mimarz mimarz commented Oct 4, 2022

resolves #2387

@mimarz mimarz changed the title ✨ Autocomplete: Support for toggling if search is cleared on change ✨ Autocomplete: Support for toggling if input is cleared on change Oct 4, 2022
@mimarz mimarz marked this pull request as ready for review October 4, 2022 13:14
@oddvernes
Copy link
Collaborator

with clearSearchOnChange={false} Perhaps it should clear input when dropdown closes though? otherwise one might be tricked to click the clear button to remove the input, but this clears all selected

@mimarz mimarz force-pushed the fix/MIM-2387-autocomplete-scroll-into-focus branch from bd973f9 to 27e7d22 Compare October 4, 2022 15:20
@mimarz mimarz changed the title ✨ Autocomplete: Support for toggling if input is cleared on change ✨ Autocomplete: Support for toggling if input is cleared on selection Oct 4, 2022
oddvernes
oddvernes approved these changes Oct 5, 2022
View reviewed changes
Copy link
Collaborator

@oddvernes oddvernes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mimarz mimarz merged commit f79293f into develop Oct 5, 2022
@mimarz mimarz deleted the fix/MIM-2387-autocomplete-scroll-into-focus branch October 5, 2022 10:41
@oddvernes oddvernes mentioned this pull request Oct 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oddvernes oddvernes oddvernes approved these changes

@vnys vnys Awaiting requested review from vnys vnys is a code owner

@martalalik martalalik Awaiting requested review from martalalik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autocomplete automatically scrolls to top after searching for option and selecting it.
2 participants
@mimarz @oddvernes