Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚚Move SideBar to core-react #2614

Merged
merged 3 commits into from
Oct 21, 2022
Merged

🚚Move SideBar to core-react #2614

merged 3 commits into from
Oct 21, 2022

Conversation

oddvernes
Copy link
Collaborator

resolves #2512

@oddvernes oddvernes force-pushed the feature/OOVE-2512-sidebar-to-core-react branch from 710ff45 to 6bfe0c4 Compare October 20, 2022 12:36
@oddvernes oddvernes changed the title 🚚Copy SideBar to core-react 🚚Move SideBar to core-react Oct 20, 2022
mimarz
mimarz approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@oddvernes oddvernes merged commit 8261ac3 into develop Oct 21, 2022
@oddvernes oddvernes deleted the feature/OOVE-2512-sidebar-to-core-react branch October 21, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz mimarz approved these changes

@vnys vnys Awaiting requested review from vnys vnys is a code owner

@denektenina denektenina Awaiting requested review from denektenina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate sidebar to core-react
2 participants
@oddvernes @mimarz