Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 Visually disable components that have aria-disabled #2624

Merged
merged 6 commits into from
Oct 26, 2022

Conversation

denektenina
Copy link
Contributor

resolves #2544

@denektenina denektenina changed the title 💄Visually disable components that have aria-disabled 🚸 Visually disable components that have aria-disabled Oct 24, 2022
@denektenina denektenina force-pushed the feature/nande-2544-aria-disabled branch from cce3366 to 6404a57 Compare October 24, 2022 08:48
@denektenina denektenina marked this pull request as ready for review October 24, 2022 10:47
Copy link
Collaborator

@oddvernes oddvernes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@denektenina denektenina merged commit d6133e1 into develop Oct 26, 2022
vnys pushed a commit that referenced this pull request Oct 30, 2022
* 💄 Add disabled styling for aria-disabled buttons

* 📝 Update Storybook to mention aria-disabled

* ✅ Updated snapshot

* ✅ Updated snapshots

* Updated story

* Added tooltip

Co-authored-by: oddvernes <oddbjorn.overnes@gmail.com>
@oddvernes oddvernes deleted the feature/nande-2544-aria-disabled branch February 21, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visually disable components that have aria-disabled?
2 participants