Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️ Upgraded downshift to 7.0.1 #2637

Merged
merged 3 commits into from
Nov 4, 2022
Merged

⬆️ Upgraded downshift to 7.0.1 #2637

merged 3 commits into from
Nov 4, 2022

Conversation

denektenina
Copy link
Contributor

resolves #2633

@oddvernes
Copy link
Collaborator

Need to update snapshots for the components changed 📸

@mimarz
Copy link
Contributor

mimarz commented Nov 2, 2022 •
edited
Loading

Might I suggest its maybe time to remove MultiSelect and SingleSelect (in a separate issue ofc)? 🙂

@oddvernes
Copy link
Collaborator

Might I suggest its maybe time to remove MultiSelect and SingleSelect (in a separate issue ofc)? 🙂

We literally discussed this yesterday, and that is indeed the plan (in a seperate issue) 😀

@oddvernes
Copy link
Collaborator

Downshift should be updated in eds-labs-react too since it is used by TimePicker

@denektenina denektenina changed the title ⬆️ upgraded downshift to 7.0.1 ⬆️ Upgraded downshift to 7.0.1 Nov 2, 2022
oddvernes
oddvernes approved these changes Nov 4, 2022
View reviewed changes
Copy link
Collaborator

@oddvernes oddvernes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! release is done so now this can be merged

@denektenina denektenina merged commit 88bf320 into develop Nov 4, 2022
@denektenina denektenina deleted the nande/2633-update-downshift branch November 4, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oddvernes oddvernes oddvernes approved these changes

@mimarz mimarz Awaiting requested review from mimarz

@vnys vnys Awaiting requested review from vnys vnys is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Downshift to 7.0.x
3 participants
@denektenina @oddvernes @mimarz