✨ Input: Added css-variable to override background #2718
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2712
From before, which I did not even realize until I updated snapshots, is that the colors from token are already wrapped in a css-variable with the color as fallback. So technically you can (and some people probably do already) use that. But since that is a core token (
--eds_ui_background__light
) which will most likely change with the new token system, I think it is still better to have a local variable that won't randomly change in the future