Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added css variables for typography colors #2840

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Added css variables for typography colors #2840

merged 1 commit into from
Mar 31, 2023

Conversation

bjartebore
Copy link
Contributor

@bjartebore bjartebore commented Mar 30, 2023 •
edited by oddvernes
Loading

Resolves #2839

@oddvernes
Copy link
Collaborator

This was certainly missing 😅! I will test that it works and then we'll have to make a new release of eds-tokens.

Be aware though, that the process that will eventually lead to this "figma-broker" (along with the current eds-tokens) being deprecated has started, but it is likely to take a good while to figure out and implement the new token system. That will also cause the naming of css-variables coming from tokens to change, so will be a large breaking change when that time comes for people using these 😬.

@bjartebore
Copy link
Contributor Author

Good to know, but a problem for the future :) Right now this is the shortest way to add some custom coloring to text

oddvernes
oddvernes approved these changes Mar 31, 2023
View reviewed changes
Copy link
Collaborator

@oddvernes oddvernes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oddvernes oddvernes merged commit dc22469 into equinor:develop Mar 31, 2023
oddvernes added a commit that referenced this pull request Mar 31, 2023
@oddvernes
✨ Changes related to #2840 (typography vars)
1f43383
oddvernes added a commit that referenced this pull request Apr 12, 2023
@oddvernes
🔖Prepare release for eds-tokens@0.9.1 (#2843)
e6f8b83 
* ✨ Changes related to #2840 (typography vars)

* 📝 Updated changelog

* 🔖 bump version

* 📸 Update snapshots

* update date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oddvernes oddvernes oddvernes approved these changes

@vnys vnys Awaiting requested review from vnys vnys is a code owner

@denektenina denektenina Awaiting requested review from denektenina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

css variables for typography colors
2 participants
@bjartebore @oddvernes