⬆️ Styled components v6 #3050
Merged
⬆️ Styled components v6 #3050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2884
This was a big one.
styled changed from default to named importedit: this was not compatible with v5, so changing back and turning off the warning insteadThey added types internally, deprecating
@types/styled-components, but the types are not 1:1 and a bunch of types are missing. At least some of these will be added back in the next release of styled components though 🤷♂️.Had to refactor how types are assigned to props on some components
Automatic filtering of props has been removed, so now every prop used in a styled component must be transient (have
$added to the front of it) otherwise it gets forwarded to the DOM as invalid props. I had to go through every component and detect all the props that needed to be transient.All snapshots have changed since sc no longer adds vendor prefixes + some other changes due to new version of stylis formats css differently
Had to change many other tests too due to stylis not trimming spaces any more