Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚸Search: remove clear button when disabled #3054

Merged
merged 3 commits into from
Sep 18, 2023
Merged

🚸Search: remove clear button when disabled #3054

merged 3 commits into from
Sep 18, 2023

Conversation

denektenina
Copy link
Contributor

resolves #3053

oddvernes
oddvernes approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@oddvernes oddvernes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@oddvernes oddvernes changed the title nande/3053 clear search 🚸Search: remove clear button when disabled Sep 18, 2023
@denektenina denektenina merged commit 3de9c75 into develop Sep 18, 2023
3 checks passed
@denektenina denektenina deleted the nande/3053_clear_search branch September 18, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oddvernes oddvernes oddvernes approved these changes

@vnys vnys Awaiting requested review from vnys vnys is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search: clear button should also be disabled when search is disabled?
2 participants
@denektenina @oddvernes