Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test #523

Merged
merged 12 commits into from
Aug 28, 2020
Merged

Fix test #523

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
761901a
First try for typescript support for Divider
wenche Aug 26, 2020
37ea8b8
In the middle of using proptables from ts components in the storybook
wenche Aug 27, 2020
e84993f
Lot's of lot's of tweeks to make prop tables in storybook working. Th…
wenche Aug 27, 2020
9a819c7
Remove classname, key and ref from props table
wenche Aug 28, 2020
166e24d
Removed debug env
wenche Aug 28, 2020
ca7a682
Removed configuration of typescript in storybook main
wenche Aug 28, 2020
97a8092
Remove old testing stuffs
wenche Aug 28, 2020
c170916
Remove old rollup typescript plugin
wenche Aug 28, 2020
737500b
Delete copy'n pasted babel typescript transpiler, we use rollup plugi…
wenche Aug 28, 2020
a1fadc6
Remove testing stuffs
wenche Aug 28, 2020
beeeaf4
Fix test
wenche Aug 28, 2020
8af2055
Merge branch 'typescript' into types-for-divider
wenche Aug 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions libraries/core-react/src/Divider/Divider.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ describe('Divider', () => {
expect(container.firstChild).toHaveStyleRule('margin-top', spacingMedium)
})
it('Sets backgroundColor to light according to color prop', () => {
const { container } = render(<Divider />)
const { container } = render(<Divider color="light" />)
expect(container.firstChild).toHaveStyleRule('background-color', light)
})
it('Sets backgroundColor to lighter according to color prop', () => {
Expand All @@ -41,9 +41,7 @@ describe('Divider', () => {
expect(container.firstChild).toHaveStyleRule('margin-top', spacingSmall)
})
it('Can extend the css for the component', () => {
const { container } = render(
<StyledDivider color="light" variant="small" />,
)
const { container } = render(<StyledDivider variant="small" />)
expect(container.firstChild).toHaveStyleRule('position', 'relative')
expect(container.firstChild).toHaveStyleRule('margin-top', spacingSmall)
})
Expand Down