Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release core-react v0.6.0 & tokens v0.4.0 #536

Merged
merged 8 commits into from
Sep 3, 2020
Merged

Release core-react v0.6.0 & tokens v0.4.0 #536

merged 8 commits into from
Sep 3, 2020

Conversation

mimarz
Copy link
Contributor

@mimarz mimarz commented Sep 2, 2020 •
edited
Loading

Preparing new release

  • core-react v0.6.0
  • tokens v0.4.0
  • Update component status

@mimarz mimarz mentioned this pull request Sep 2, 2020
Merged
pomfrida
pomfrida approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@pomfrida pomfrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

vnys
vnys requested changes Sep 3, 2020
View reviewed changes
Copy link
Member

@vnys vnys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to bump the version of the storybook to the same version as the react components. And use lists in the changelog even though there’s only one item.

libraries/tokens/CHANGELOG.md Outdated Show resolved Hide resolved
libraries/tokens/CHANGELOG.md Outdated Show resolved Hide resolved
libraries/tokens/CHANGELOG.md Outdated Show resolved Hide resolved
libraries/tokens/CHANGELOG.md Outdated Show resolved Hide resolved
libraries/tokens/CHANGELOG.md Outdated Show resolved Hide resolved
libraries/tokens/CHANGELOG.md Outdated Show resolved Hide resolved
@mimarz mimarz requested a review from vnys September 3, 2020 07:09
vnys
vnys approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@vnys vnys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mimarz mimarz merged commit aea7d50 into equinor:develop Sep 3, 2020
@mimarz mimarz deleted the release/v0.6.0 branch September 3, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pomfrida pomfrida pomfrida approved these changes

@vnys vnys vnys approved these changes

@wenche wenche Awaiting requested review from wenche

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mimarz @vnys @pomfrida