Skip to content

Commit

Permalink
efficients etc (#292)
Browse files Browse the repository at this point in the history
  • Loading branch information
fannemel authored Jan 18, 2022
1 parent 91b693f commit 4020a77
Show file tree
Hide file tree
Showing 121 changed files with 816 additions and 747 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ public sysNewtonRhapson(SystemInterface system, int numberOfPhases, int numberOf
public void setfvec() {
for (int i = 0; i < numberOfComponents; i++) {
fvec.set(i, 0, u.get(i, 0)
+ Math.log(system.getPhases()[1].getComponents()[i].getFugasityCoeffisient()
/ system.getPhases()[0].getComponents()[i].getFugasityCoeffisient()));
+ Math.log(system.getPhases()[1].getComponents()[i].getFugacityCoefficient()
/ system.getPhases()[0].getComponents()[i].getFugacityCoefficient()));
}
double fsum = 0.0;
for (int i = 0; i < numberOfComponents; i++) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -391,9 +391,9 @@ public double step() {
return step;
} else {
// chem_pot_omega[i] = R*T*(chem_ref[i]+ Math.log(n_omega[i]/n_t) +
// Math.log(system.getPhases()[1].getComponents()[components[i].getComponentNumber()].getFugasityCoeffisient()/chem_pot_pure[i]));
// Math.log(system.getPhases()[1].getComponents()[components[i].getComponentNumber()].getFugacityCoefficient()/chem_pot_pure[i]));
// chem_pot[i] = R*T*(chem_ref[i] + Math.log(n_mol[i]/n_t)+
// Math.log(system.getPhases()[1].getComponents()[components[i].getComponentNumber()].getFugasityCoeffisient()/chem_pot_pure[i]));
// Math.log(system.getPhases()[1].getComponents()[components[i].getComponentNumber()].getFugacityCoefficient()/chem_pot_pure[i]));

if (system.getPhase(phasenumb).getComponents()[components[i].getComponentNumber()]
.getReferenceStateType().equals("solvent")) {
Expand All @@ -402,14 +402,14 @@ public double step() {
.getComponentNumber()].getNumberOfMolesInPhase())
- Math.log(n_t) + logactivityVec[i]);// system.getPhase(phasenumb).getActivityCoefficient(components[i].getComponentNumber(),components[waterNumb].getComponentNumber())));
// System.out.println("solvent activ: "+ i + " " +
// system.getPhases()[1].getComponents()[components[i].getComponentNumber()].getFugasityCoeffisient()/chem_pot_pure[i]);
// system.getPhases()[1].getComponents()[components[i].getComponentNumber()].getFugacityCoefficient()/chem_pot_pure[i]);
} else {
chem_pot[i] = R * system.getPhase(phasenumb).getTemperature() * (chem_ref[i]
+ Math.log(system.getPhase(phasenumb).getComponents()[components[i]
.getComponentNumber()].getNumberOfMolesInPhase())
- Math.log(n_t) + logactivityVec[i]);// system.getPhase(phasenumb).getActivityCoefficient(components[i].getComponentNumber(),components[waterNumb].getComponentNumber())));
// System.out.println("solute activ : " + i + " " +
// system.getPhases()[1].getComponents()[components[i].getComponentNumber()].getFugasityCoeffisient()/chem_pot_dilute[i]);
// system.getPhases()[1].getComponents()[components[i].getComponentNumber()].getFugacityCoefficient()/chem_pot_dilute[i]);
}
chem_pot_omega[i] = R * system.getPhase(phasenumb).getTemperature()
* (chem_ref[i] + Math.log(n_omega[i]) - Math.log(n_t) + logactivityVec[i]);
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/neqsim/fluidMechanics/flowLeg/FlowLeg.java
Original file line number Diff line number Diff line change
Expand Up @@ -159,15 +159,15 @@ public void setHeightCoordinates(double startHeightCoordinate, double endHeightC

/** {@inheritDoc} */
@Override
public void setOuterHeatTransferCOefficients(double startHeatTransferCoefficient,
public void setOuterHeatTransferCoefficients(double startHeatTransferCoefficient,
double endHeatTransferCoefficient) {
this.startOuterHeatTransferCoefficient = startHeatTransferCoefficient;
this.endOuterHeatTransferCoefficient = endHeatTransferCoefficient;
}

/** {@inheritDoc} */
@Override
public void setWallHeatTransferCOefficients(double startHeatTransferCoefficient,
public void setWallHeatTransferCoefficients(double startHeatTransferCoefficient,
double endHeatTransferCoefficient) {
this.startWallHeatTransferCOefficients = startHeatTransferCoefficient;
this.endWallHeatTransferCOefficients = endHeatTransferCoefficient;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -123,24 +123,24 @@ public void setLongitudionalCoordinates(double startLongitudionalCoordinate,

/**
* <p>
* setOuterHeatTransferCOefficients.
* setOuterHeatTransferCoefficients.
* </p>
*
* @param startHeatTransferCoefficient a double
* @param endHeatTransferCoefficient a double
*/
public void setOuterHeatTransferCOefficients(double startHeatTransferCoefficient,
public void setOuterHeatTransferCoefficients(double startHeatTransferCoefficient,
double endHeatTransferCoefficient);

/**
* <p>
* setWallHeatTransferCOefficients.
* setWallHeatTransferCoefficients.
* </p>
*
* @param startHeatTransferCoefficient a double
* @param endHeatTransferCoefficient a double
*/
public void setWallHeatTransferCOefficients(double startHeatTransferCoefficient,
public void setWallHeatTransferCoefficients(double startHeatTransferCoefficient,
double endHeatTransferCoefficient);

/**
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/neqsim/fluidMechanics/flowNode/FlowNode.java
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,7 @@ public double getPrandtlNumber(int phase) {
@Override
public double getSchmidtNumber(int phase, int component1, int component2) {
return getBulkSystem().getPhase(phase).getPhysicalProperties()
.getDiffusionCoeffisient(component1, component2)
.getDiffusionCoefficient(component1, component2)
/ getBulkSystem().getPhase(phase).getPhysicalProperties().getKinematicViscosity();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -658,9 +658,9 @@ public interface FlowNodeInterface extends Cloneable {
*/
public DoubleCloneable getVelocityIn(int i);

// public double calcWallHeatTransferCoeffisient(int phase);
// public double calcWallHeatTransferCoefficient(int phase);

// public double calcWallMassTransferCoeffisient(double schmidtNumber, int phase);
// public double calcWallMassTransferCoefficient(double schmidtNumber, int phase);

/**
* <p>
Expand All @@ -673,9 +673,9 @@ public interface FlowNodeInterface extends Cloneable {
public double calcTotalHeatTransferCoefficient(int phase);

// public double initVelocity();
// public double calcInterphaseMassTransferCoeffisient(double schmidtNumber, int
// public double calcInterphaseMassTransferCoefficient(double schmidtNumber, int
// phase);
// public double calcInterphaseHeatTransferCoeffisient(int phase);
// public double calcInterphaseHeatTransferCoefficient(int phase);
// public double calcdPdz();
// public double calcdTdz();
// public double calcdVoiddz();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,10 @@ public void setfvecMassTrans() {
double sumx = 0, sumy = 0;
for (int i = 0; i < bulkSystem.getPhases()[0].getNumberOfComponents(); i++) {
fvec.set(i, 0, Math.log(
(interphaseSystem.getPhases()[0].getComponents()[i].getFugasityCoeffisient()
(interphaseSystem.getPhases()[0].getComponents()[i].getFugacityCoefficient()
* interphaseSystem.getPhases()[0].getComponents()[i].getx()))
- Math.log((interphaseSystem.getPhases()[1].getComponents()[i]
.getFugasityCoeffisient()
.getFugacityCoefficient()
* interphaseSystem.getPhases()[1].getComponents()[i].getx())));
sumx += interphaseSystem.getPhases()[0].getComponents()[i].getx();
sumy += interphaseSystem.getPhases()[1].getComponents()[i].getx();
Expand Down Expand Up @@ -162,10 +162,10 @@ public void setfvecMassTrans2() {
double sumx = 0.0, sumy = 0.0;
for (int i = 0; i < bulkSystem.getPhases()[0].getNumberOfComponents(); i++) {
fvec.set(i, 0, Math.log(
(interphaseSystem.getPhases()[0].getComponents()[i].getFugasityCoeffisient()
(interphaseSystem.getPhases()[0].getComponents()[i].getFugacityCoefficient()
* interphaseSystem.getPhases()[0].getComponents()[i].getx()))
- Math.log((interphaseSystem.getPhases()[1].getComponents()[i]
.getFugasityCoeffisient()
.getFugacityCoefficient()
* interphaseSystem.getPhases()[1].getComponents()[i].getx())));
sumx += interphaseSystem.getPhases()[1].getComponents()[i].getx();
sumy += interphaseSystem.getPhases()[0].getComponents()[i].getx();
Expand Down Expand Up @@ -249,7 +249,7 @@ public void setJacMassTrans() {
+ interphaseSystem.getPhases()[0].getComponents()[i].getdfugdx(j);

// tempJ=
// dij*interphaseSystem.getPhases()[0].getComponents()[i].getFugasityCoeffisient()+interphaseSystem.getPhases()[0].getComponents()[i].getx()*interphaseSystem.getPhases()[0].getComponents()[i].getdfugdx(j);
// dij*interphaseSystem.getPhases()[0].getComponents()[i].getFugacityCoefficient()+interphaseSystem.getPhases()[0].getComponents()[i].getx()*interphaseSystem.getPhases()[0].getComponents()[i].getdfugdx(j);
Jac.set(i, j, tempJ);
}
}
Expand All @@ -270,7 +270,7 @@ public void setJacMassTrans() {
+ interphaseSystem.getPhases()[1].getComponents()[i].getdfugdx(j);

// tempJ=
// dij*interphaseSystem.getPhases()[1].getComponents()[i].getFugasityCoeffisient()+interphaseSystem.getPhases()[1].getComponents()[i].getx()*interphaseSystem.getPhases()[1].getComponents()[i].getdfugdx(j);
// dij*interphaseSystem.getPhases()[1].getComponents()[i].getFugacityCoefficient()+interphaseSystem.getPhases()[1].getComponents()[i].getx()*interphaseSystem.getPhases()[1].getComponents()[i].getdfugdx(j);
Jac.set(i, j + bulkSystem.getPhases()[0].getNumberOfComponents(), -tempJ);
}
}
Expand Down Expand Up @@ -448,12 +448,12 @@ public void calcMolFractionDifference() {

/**
* <p>
* calcHeatTransferCoeffisients.
* calcHeatTransferCoefficients.
* </p>
*
* @param phase a int
*/
public void calcHeatTransferCoeffisients(int phase) {
public void calcHeatTransferCoefficients(int phase) {
prandtlNumber[phase] = getBulkSystem().getPhases()[phase].getCp()
/ getBulkSystem().getPhases()[phase].getNumberOfMolesInPhase()
* getBulkSystem().getPhases()[phase].getPhysicalProperties().getViscosity()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@
import neqsim.thermodynamicOperations.ThermodynamicOperations;

/**
* <p>KrishnaStandartFilmModel class.</p>
* <p>
* KrishnaStandartFilmModel class.
* </p>
*
* @author asmund
* @version $Id: $Id
Expand All @@ -26,12 +28,16 @@ public class KrishnaStandartFilmModel extends
Matrix betaMatrix;

/**
* <p>Constructor for KrishnaStandartFilmModel.</p>
* <p>
* Constructor for KrishnaStandartFilmModel.
* </p>
*/
public KrishnaStandartFilmModel() {}

/**
* <p>Constructor for KrishnaStandartFilmModel.</p>
* <p>
* Constructor for KrishnaStandartFilmModel.
* </p>
*
* @param system a {@link neqsim.thermo.system.SystemInterface} object
*/
Expand All @@ -48,7 +54,9 @@ public KrishnaStandartFilmModel(SystemInterface system) {
}

/**
* <p>Constructor for KrishnaStandartFilmModel.</p>
* <p>
* Constructor for KrishnaStandartFilmModel.
* </p>
*
* @param flowNode a {@link neqsim.fluidMechanics.flowNode.FlowNodeInterface} object
*/
Expand Down Expand Up @@ -83,7 +91,9 @@ public KrishnaStandartFilmModel clone() {
}

/**
* <p>calcBinarySchmidtNumbers.</p>
* <p>
* calcBinarySchmidtNumbers.
* </p>
*
* @param phase a int
* @return a double
Expand All @@ -94,10 +104,10 @@ public double calcBinarySchmidtNumbers(int phase) {
binarySchmidtNumber[phase][i][j] = getBulkSystem().getPhases()[phase]
.getPhysicalProperties().getKinematicViscosity()
/ getBulkSystem().getPhases()[phase].getPhysicalProperties()
.getDiffusionCoeffisient(i, j);
.getDiffusionCoefficient(i, j);
// System.out.println("i j " + i +" j " + j);
// System.out.println("phase " + phase + " diff" +
// getBulkSystem().getPhases()[phase].getPhysicalProperties().getDiffusionCoeffisient(i,j));
// getBulkSystem().getPhases()[phase].getPhysicalProperties().getDiffusionCoefficient(i,j));
// System.out.println("phase " + phase + " visk" +
// getBulkSystem().getPhases()[phase].getPhysicalProperties().getKinematicViscosity());
}
Expand All @@ -106,7 +116,9 @@ public double calcBinarySchmidtNumbers(int phase) {
}

/**
* <p>calcBinaryMassTransferCoefficients.</p>
* <p>
* calcBinaryMassTransferCoefficients.
* </p>
*
* @param phase a int
* @return a double
Expand All @@ -123,12 +135,14 @@ public double calcBinaryMassTransferCoefficients(int phase) {
}

/**
* <p>calcMassTransferCoeffisients.</p>
* <p>
* calcMassTransferCoefficients.
* </p>
*
* @param phase a int
* @return a double
*/
public double calcMassTransferCoeffisients(int phase) {
public double calcMassTransferCoefficients(int phase) {
int n = getBulkSystem().getPhases()[phase].getNumberOfComponents() - 1;

for (int i = 0; i < getBulkSystem().getPhases()[phase].getNumberOfComponents() - 1; i++) {
Expand All @@ -154,7 +168,9 @@ public double calcMassTransferCoeffisients(int phase) {
}

/**
* <p>calcPhiMatrix.</p>
* <p>
* calcPhiMatrix.
* </p>
*
* @param phase a int
*/
Expand Down Expand Up @@ -187,7 +203,9 @@ public void calcPhiMatrix(int phase) {
}

/**
* <p>calcRedPhiMatrix.</p>
* <p>
* calcRedPhiMatrix.
* </p>
*
* @param phase a int
*/
Expand All @@ -196,7 +214,9 @@ public void calcRedPhiMatrix(int phase) {
}

/**
* <p>calcRedCorrectionMatrix.</p>
* <p>
* calcRedCorrectionMatrix.
* </p>
*
* @param phase a int
*/
Expand All @@ -209,7 +229,9 @@ public void calcRedCorrectionMatrix(int phase) {
}

/**
* <p>calcCorrectionMatrix.</p>
* <p>
* calcCorrectionMatrix.
* </p>
*
* @param phase a int
*/
Expand All @@ -226,7 +248,9 @@ public void calcCorrectionMatrix(int phase) {
}

/**
* <p>calcTotalMassTransferCoefficientMatrix.</p>
* <p>
* calcTotalMassTransferCoefficientMatrix.
* </p>
*
* @param phase a int
*/
Expand Down Expand Up @@ -257,7 +281,9 @@ public void calcTotalMassTransferCoefficientMatrix(int phase) {
}

/**
* <p>initCorrections.</p>
* <p>
* initCorrections.
* </p>
*
* @param phase a int
*/
Expand All @@ -280,7 +306,7 @@ public void initMassTransferCalc() {
for (int phase = 0; phase < 2; phase++) {
this.calcBinarySchmidtNumbers(phase);
this.calcBinaryMassTransferCoefficients(phase);
this.calcMassTransferCoeffisients(phase);
this.calcMassTransferCoefficients(phase);
this.initCorrections(phase);
this.calcNonIdealCorrections(phase);
// this.calcFluxTypeCorrectionMatrix(phase,0);
Expand All @@ -293,7 +319,7 @@ public void initMassTransferCalc() {
public void initHeatTransferCalc() {
super.initHeatTransferCalc();
for (int phase = 0; phase < 2; phase++) {
this.calcHeatTransferCoeffisients(phase);
this.calcHeatTransferCoefficients(phase);
this.calcHeatTransferCorrection(phase);
}
}
Expand All @@ -317,7 +343,9 @@ public void solve() {
}

/**
* <p>main.</p>
* <p>
* main.
* </p>
*
* @param args an array of {@link java.lang.String} objects
*/
Expand Down
Loading

0 comments on commit 4020a77

Please sign in to comment.