chore: fixed warnings

equinor · Aug 8, 2024 · 7feea52 · 7feea52
1 parent 7612ec4
commit 7feea52
Show file tree

Hide file tree

Showing 16 changed files with 229 additions and 204 deletions.
diff --git a/...ocessSimulation/mechanicalDesign/designStandards/AdsorptionDehydrationDesignStandard.java b/...ocessSimulation/mechanicalDesign/designStandards/AdsorptionDehydrationDesignStandard.java
@@ -29,34 +29,38 @@ public class AdsorptionDehydrationDesignStandard extends DesignStandard {
   public AdsorptionDehydrationDesignStandard(String name, MechanicalDesign equipmentInn) {
     super(name, equipmentInn);
 
-    final neqsim.util.database.NeqSimProcessDesignDataBase database =
-        new neqsim.util.database.NeqSimProcessDesignDataBase();
-    java.sql.ResultSet dataSet = null;
-    try {
+    try (neqsim.util.database.NeqSimProcessDesignDataBase database =
+        new neqsim.util.database.NeqSimProcessDesignDataBase()) {
+      java.sql.ResultSet dataSet = null;
       try {
-        dataSet = database.getResultSet(
-            ("SELECT * FROM technicalrequirements_process WHERE EQUIPMENTTYPE='Adsorber Dehydration' AND Company='"
-                + standardName + "'"));
-        while (dataSet.next()) {
-          String specName = dataSet.getString("SPECIFICATION");
-          if (specName.equals("MolecularSieve3AWaterCapacity")) {
-            molecularSieveWaterCapacity = Double.parseDouble(dataSet.getString("MAXVALUE"));
+        try {
+          dataSet = database.getResultSet(
+              ("SELECT * FROM technicalrequirements_process WHERE EQUIPMENTTYPE='Adsorber Dehydration' AND Company='"
+                  + standardName + "'"));
+          while (dataSet.next()) {
+            String specName = dataSet.getString("SPECIFICATION");
+            if (specName.equals("MolecularSieve3AWaterCapacity")) {
+              molecularSieveWaterCapacity = Double.parseDouble(dataSet.getString("MAXVALUE"));
+            }
           }
+        } catch (Exception ex) {
+          logger.error(ex.getMessage(), ex);
         }
       } catch (Exception ex) {
         logger.error(ex.getMessage(), ex);
-      }
-    } catch (Exception ex) {
-      logger.error(ex.getMessage(), ex);
-    } finally {
-      try {
-        if (dataSet != null) {
-          dataSet.close();
+      } finally {
+        try {
+          if (dataSet != null) {
+            dataSet.close();
+          }
+        } catch (Exception ex) {
+          System.out.println("error closing database.....GasScrubberDesignStandard");
+          logger.error(ex.getMessage(), ex);
         }
-      } catch (Exception ex) {
-        System.out.println("error closing database.....GasScrubberDesignStandard");
-        logger.error(ex.getMessage(), ex);
       }
+    } catch (Exception e) {
+      // TODO Auto-generated catch block
+      e.printStackTrace();
     }
   }
 

diff --git a/...a/neqsim/processSimulation/mechanicalDesign/designStandards/CompressorDesignStandard.java b/...a/neqsim/processSimulation/mechanicalDesign/designStandards/CompressorDesignStandard.java
@@ -29,22 +29,25 @@ public class CompressorDesignStandard extends DesignStandard {
   public CompressorDesignStandard(String name, MechanicalDesign equipmentInn) {
     super(name, equipmentInn);
 
-    neqsim.util.database.NeqSimProcessDesignDataBase database =
-        new neqsim.util.database.NeqSimProcessDesignDataBase();
-
-    try (java.sql.ResultSet dataSet = database.getResultSet(
-        ("SELECT * FROM technicalrequirements_process WHERE EQUIPMENTTYPE='Compressor' AND Company='"
-            + standardName + "'"))) {
-      while (dataSet.next()) {
-        String specName = dataSet.getString("SPECIFICATION");
-        if (specName.equals("compressorFactor")) {
-          compressorFactor = Double.parseDouble(dataSet.getString("MAXVALUE"));
+    try (neqsim.util.database.NeqSimProcessDesignDataBase database =
+        new neqsim.util.database.NeqSimProcessDesignDataBase()) {
+      try (java.sql.ResultSet dataSet = database.getResultSet(
+          ("SELECT * FROM technicalrequirements_process WHERE EQUIPMENTTYPE='Compressor' AND Company='"
+              + standardName + "'"))) {
+        while (dataSet.next()) {
+          String specName = dataSet.getString("SPECIFICATION");
+          if (specName.equals("compressorFactor")) {
+            compressorFactor = Double.parseDouble(dataSet.getString("MAXVALUE"));
+          }
         }
+      } catch (Exception ex) {
+        logger.error(ex.getMessage(), ex);
       }
-    } catch (Exception ex) {
-      logger.error(ex.getMessage(), ex);
+      // gasLoadFactor = Double.parseDouble(dataSet.getString("gasloadfactor"));
+    } catch (Exception e) {
+      // TODO Auto-generated catch block
+      e.printStackTrace();
     }
-    // gasLoadFactor = Double.parseDouble(dataSet.getString("gasloadfactor"));
   }
 
   /**

diff --git a/.../neqsim/processSimulation/mechanicalDesign/designStandards/GasScrubberDesignStandard.java b/.../neqsim/processSimulation/mechanicalDesign/designStandards/GasScrubberDesignStandard.java
@@ -33,42 +33,46 @@ public class GasScrubberDesignStandard extends DesignStandard {
   public GasScrubberDesignStandard(String name, MechanicalDesign equipmentInn) {
     super(name, equipmentInn);
 
-    neqsim.util.database.NeqSimProcessDesignDataBase database =
-        new neqsim.util.database.NeqSimProcessDesignDataBase();
-    java.sql.ResultSet dataSet = null;
-    try {
+    try (neqsim.util.database.NeqSimProcessDesignDataBase database =
+        new neqsim.util.database.NeqSimProcessDesignDataBase()) {
+      java.sql.ResultSet dataSet = null;
       try {
-        dataSet = database.getResultSet(
-            ("SELECT * FROM technicalrequirements_process WHERE EQUIPMENTTYPE='Gas scrubber' AND Company='"
-                + standardName + "'"));
-        while (dataSet.next()) {
-          String specName = dataSet.getString("SPECIFICATION");
-          if (specName.equals("GasLoadFactor")) {
-            gasLoadFactor = Double.parseDouble(dataSet.getString("MAXVALUE"));
-          } else if (specName.equals("FlowDesignFactor")) {
-            designFactorVolumeFlow = Double.parseDouble(dataSet.getString("MAXVALUE"));
-          } else if (specName.equals("LengthGasInetToHHLL")) {
-            designFactorVolumeFlow = Double.parseDouble(dataSet.getString("MINVALUE"));
-          } else if (specName.equals("LengthMeshPadToDemistingCyclone")) {
-            designFactorVolumeFlow = Double.parseDouble(dataSet.getString("MINVALUE"));
+        try {
+          dataSet = database.getResultSet(
+              ("SELECT * FROM technicalrequirements_process WHERE EQUIPMENTTYPE='Gas scrubber' AND Company='"
+                  + standardName + "'"));
+          while (dataSet.next()) {
+            String specName = dataSet.getString("SPECIFICATION");
+            if (specName.equals("GasLoadFactor")) {
+              gasLoadFactor = Double.parseDouble(dataSet.getString("MAXVALUE"));
+            } else if (specName.equals("FlowDesignFactor")) {
+              designFactorVolumeFlow = Double.parseDouble(dataSet.getString("MAXVALUE"));
+            } else if (specName.equals("LengthGasInetToHHLL")) {
+              designFactorVolumeFlow = Double.parseDouble(dataSet.getString("MINVALUE"));
+            } else if (specName.equals("LengthMeshPadToDemistingCyclone")) {
+              designFactorVolumeFlow = Double.parseDouble(dataSet.getString("MINVALUE"));
+            }
           }
+        } catch (Exception ex) {
+          logger.error(ex.getMessage(), ex);
         }
-      } catch (Exception ex) {
-        logger.error(ex.getMessage(), ex);
-      }
 
-      // gasLoadFactor = Double.parseDouble(dataSet.getString("gasloadfactor"));
-    } catch (Exception ex) {
-      logger.error(ex.getMessage(), ex);
-    } finally {
-      try {
-        if (dataSet != null) {
-          dataSet.close();
-        }
+        // gasLoadFactor = Double.parseDouble(dataSet.getString("gasloadfactor"));
       } catch (Exception ex) {
-        System.out.println("error closing database.....GasScrubberDesignStandard");
         logger.error(ex.getMessage(), ex);
+      } finally {
+        try {
+          if (dataSet != null) {
+            dataSet.close();
+          }
+        } catch (Exception ex) {
+          System.out.println("error closing database.....GasScrubberDesignStandard");
+          logger.error(ex.getMessage(), ex);
+        }
       }
+    } catch (Exception e) {
+      // TODO Auto-generated catch block
+      e.printStackTrace();
     }
   }
 

diff --git a/...neqsim/processSimulation/mechanicalDesign/designStandards/MaterialPipeDesignStandard.java b/...neqsim/processSimulation/mechanicalDesign/designStandards/MaterialPipeDesignStandard.java
@@ -144,21 +144,25 @@ public void readMaterialDesignStandard(String specNo, String grade) {
     this.grade = grade;
     specificationNumber = specNo;
 
-    neqsim.util.database.NeqSimProcessDesignDataBase database =
-        new neqsim.util.database.NeqSimProcessDesignDataBase();
-    try (java.sql.ResultSet dataSet =
-        database.getResultSet(("SELECT * FROM materialpipeproperties WHERE specificationNumber='"
-            + specificationNumber + "' AND grade='" + grade + "'"))) {
-      while (dataSet.next()) {
-        minimumYeildStrength =
-            (Double.parseDouble(dataSet.getString("minimumYeildStrength"))) * 0.00689475729;
-        // design factor table has to be developed
-        // Efactor table has to be implemented
-        // temperatureDeratingFactor has to be implemented
+    try (neqsim.util.database.NeqSimProcessDesignDataBase database =
+        new neqsim.util.database.NeqSimProcessDesignDataBase()) {
+      try (java.sql.ResultSet dataSet =
+          database.getResultSet(("SELECT * FROM materialpipeproperties WHERE specificationNumber='"
+              + specificationNumber + "' AND grade='" + grade + "'"))) {
+        while (dataSet.next()) {
+          minimumYeildStrength =
+              (Double.parseDouble(dataSet.getString("minimumYeildStrength"))) * 0.00689475729;
+          // design factor table has to be developed
+          // Efactor table has to be implemented
+          // temperatureDeratingFactor has to be implemented
+        }
+      } catch (Exception ex) {
+        logger.error(ex.getMessage(), ex);
       }
-    } catch (Exception ex) {
-      logger.error(ex.getMessage(), ex);
+      // gasLoadFactor = Double.parseDouble(dataSet.getString("gasloadfactor"));
+    } catch (Exception e) {
+      // TODO Auto-generated catch block
+      e.printStackTrace();
     }
-    // gasLoadFactor = Double.parseDouble(dataSet.getString("gasloadfactor"));
   }
 }
diff --git a/...eqsim/processSimulation/mechanicalDesign/designStandards/MaterialPlateDesignStandard.java b/...eqsim/processSimulation/mechanicalDesign/designStandards/MaterialPlateDesignStandard.java
@@ -80,39 +80,43 @@ public void readMaterialDesignStandard(String name, String specNo, String grade,
     specificationNumber = specNo;
     divisionClassNumber = divClassNo;
 
-    neqsim.util.database.NeqSimProcessDesignDataBase database =
-        new neqsim.util.database.NeqSimProcessDesignDataBase();
-    java.sql.ResultSet dataSet = null;
-    try {
+    try (neqsim.util.database.NeqSimProcessDesignDataBase database =
+        new neqsim.util.database.NeqSimProcessDesignDataBase()) {
+      java.sql.ResultSet dataSet = null;
       try {
-        dataSet =
-            database.getResultSet(("SELECT * FROM materialplateproperties WHERE materialName='"
-                + name + "' AND grade='" + grade + "' AND specificationNumber='" + specNo + "'"));
-        while (dataSet.next()) {
-          if (divClassNo == 1) {
-            divisionClass =
-                (Double.parseDouble(dataSet.getString("divisionClass1"))) * 0.00689475729; // MPa
-          } else {
-            divisionClass =
-                (Double.parseDouble(dataSet.getString("divisionClass2"))) * 0.00689475729; // MPa
+        try {
+          dataSet =
+              database.getResultSet(("SELECT * FROM materialplateproperties WHERE materialName='"
+                  + name + "' AND grade='" + grade + "' AND specificationNumber='" + specNo + "'"));
+          while (dataSet.next()) {
+            if (divClassNo == 1) {
+              divisionClass =
+                  (Double.parseDouble(dataSet.getString("divisionClass1"))) * 0.00689475729; // MPa
+            } else {
+              divisionClass =
+                  (Double.parseDouble(dataSet.getString("divisionClass2"))) * 0.00689475729; // MPa
+            }
           }
+        } catch (Exception ex) {
+          logger.error(ex.getMessage(), ex);
         }
-      } catch (Exception ex) {
-        logger.error(ex.getMessage(), ex);
-      }
 
-      // gasLoadFactor = Double.parseDouble(dataSet.getString("gasloadfactor"));
-    } catch (Exception ex) {
-      logger.error(ex.getMessage(), ex);
-    } finally {
-      try {
-        if (dataSet != null) {
-          dataSet.close();
-        }
+        // gasLoadFactor = Double.parseDouble(dataSet.getString("gasloadfactor"));
       } catch (Exception ex) {
-        System.out.println("error closing database.....GasScrubberDesignStandard");
         logger.error(ex.getMessage(), ex);
+      } finally {
+        try {
+          if (dataSet != null) {
+            dataSet.close();
+          }
+        } catch (Exception ex) {
+          System.out.println("error closing database.....GasScrubberDesignStandard");
+          logger.error(ex.getMessage(), ex);
+        }
       }
+    } catch (Exception e) {
+      // TODO Auto-generated catch block
+      e.printStackTrace();
     }
   }
 }
diff --git a/...ava/neqsim/processSimulation/mechanicalDesign/designStandards/PipelineDesignStandard.java b/...ava/neqsim/processSimulation/mechanicalDesign/designStandards/PipelineDesignStandard.java
@@ -34,20 +34,23 @@ public PipelineDesignStandard(String name, MechanicalDesign equipmentInn) {
     // double jointEfficiency =
     // equipment.getJointEfficiencyStandard().getJEFactor();
 
-    neqsim.util.database.NeqSimProcessDesignDataBase database =
-        new neqsim.util.database.NeqSimProcessDesignDataBase();
-
-    try (java.sql.ResultSet dataSet = database.getResultSet(
-        ("SELECT * FROM technicalrequirements_process WHERE EQUIPMENTTYPE='Pipeline' AND Company='"
-            + standardName + "'"))) {
-      while (dataSet.next()) {
-        String specName = dataSet.getString("SPECIFICATION");
-        if (specName.equals("safetyFactor")) {
-          safetyFactor = Double.parseDouble(dataSet.getString("MAXVALUE"));
+    try (neqsim.util.database.NeqSimProcessDesignDataBase database =
+        new neqsim.util.database.NeqSimProcessDesignDataBase()) {
+      try (java.sql.ResultSet dataSet = database.getResultSet(
+          ("SELECT * FROM technicalrequirements_process WHERE EQUIPMENTTYPE='Pipeline' AND Company='"
+              + standardName + "'"))) {
+        while (dataSet.next()) {
+          String specName = dataSet.getString("SPECIFICATION");
+          if (specName.equals("safetyFactor")) {
+            safetyFactor = Double.parseDouble(dataSet.getString("MAXVALUE"));
+          }
         }
+      } catch (Exception ex) {
+        logger.error(ex.getMessage(), ex);
       }
-    } catch (Exception ex) {
-      logger.error(ex.getMessage(), ex);
+    } catch (Exception e) {
+      // TODO Auto-generated catch block
+      e.printStackTrace();
     }
   }