refact runTransient. Default to steady state calculation #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hall call use difference equations or steady state calculation refact: inherit runTransient if doing nothing special
|
@EvenSol Her har eg rydda i konseptet for å gjere steady state kalkulasjon når runTransient vert kalla. |
|
Looks like good clean up. Valves are initialized to be calculated dynamic (calcSteadyState=false), I guess this is ok. In the test they are set to be non-dynamic. Tee tests should by on valves running in dynamic mode I guess. |
EvenSol
approved these changes
May 25, 2022
|
the valves (and others with setcalulatesteadystate=false) are set up like that to keep their old behaviour if not specified. tests test the new behaviour |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.