Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #663

Merged
merged 4 commits into from
May 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ public static void main(String[] args) {
new neqsim.fluidMechanics.geometryDefinitions.pipe.PipeData(pipeDiameter[i]);
}
pipe.setEquipmentGeometry(pipeGemometry); // setter inn rorgeometrien for hver leg
// utforer bergninger
// utforer beregninger
pipe.createSystem();
pipe.init();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ public static void main(String[] args) {
new neqsim.fluidMechanics.geometryDefinitions.pipe.PipeData(pipeDiameter[i]);
}
pipe.setEquipmentGeometry(pipeGemometry); // setter inn rorgeometrien for hver leg
// utforer bergninger
// utforer beregninger
pipe.createSystem();
pipe.init();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public static void main(String[] args) {
new neqsim.fluidMechanics.geometryDefinitions.pipe.PipeData(pipeDiameter[i]);
}
pipe.setEquipmentGeometry(pipeGemometry); // setter inn rorgeometrien for hver leg
// utforer bergninger
// utforer beregninger
pipe.createSystem();
pipe.setEquilibriumMassTransfer(false);
pipe.setEquilibriumHeatTransfer(false);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ public static void main(String[] args) {
new neqsim.fluidMechanics.geometryDefinitions.reactor.ReactorData(pipeDiameter[i], 1);
}
pipe.setEquipmentGeometry(pipeGemometry); // setter inn rorgeometrien for hver leg
// utforer bergninger
// utforer beregninger
pipe.createSystem();
pipe.init();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ public void setSolidAdsorbentMaterial(String material) {
@Override
public void calcAdsorption() {
for (int i = 0; i < system.getNumberOfPhases(); i++) {
getAdsorptionCalc()[i].calcAdorption(i);
getAdsorptionCalc()[i].calcAdsorption(i);
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,35 @@
public interface AdsorptionInterface extends neqsim.thermo.ThermodynamicConstantsInterface {
/**
* <p>
* calcAdorption.
* calcAdsorption.
* </p>
*
* @param phase a int
*/
public void calcAdorption(int phase);
public void calcAdsorption(int phase);

/**
* <p>
* calcAdsorption.
* </p>
*
* @param phase a int
* @deprecated Replaced by {@link calcAdsorption}
*/
@Deprecated
public default void calcAdorption(int phase) {
calcAdsorption(phase);
}

/**
* <p>
* getSurfaceExcess.
* </p>
*
* @param component a int
* @return a double
*/
public double getSurfaceExcess(int component);

/**
* <p>
Expand All @@ -25,8 +48,12 @@ public interface AdsorptionInterface extends neqsim.thermo.ThermodynamicConstant
*
* @param component a int
* @return a double
* @deprecated Replaced by {@link getSurfaceExcess}
*/
public double getSurfaceExess(int component);
@Deprecated
public default double getSurfaceExess(int component) {
return getSurfaceExcess(component);
}

/**
* <p>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public void setSolidMaterial(String solidM) {

/** {@inheritDoc} */
@Override
public void calcAdorption(int phase) {
public void calcAdsorption(int phase) {
SystemInterface tempSystem = system.clone();
tempSystem.init(3);
double[] bulkFug = new double[system.getPhase(phase).getNumberOfComponents()];
Expand Down Expand Up @@ -139,6 +139,13 @@ public void calcAdorption(int phase) {
}
}

/** {@inheritDoc} */
@Override
public double getSurfaceExcess(int component) {
// todo: remove not in use
return 1.0;
}

/** {@inheritDoc} */
@Override
public double getSurfaceExcess(String componentName) {
Expand Down Expand Up @@ -178,10 +185,4 @@ public void readDBParameters() {
}
}
}

/** {@inheritDoc} */
@Override
public double getSurfaceExess(int component) {
return 1.0;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public class AdsorptionDehydrationlModule extends ProcessModuleBaseClass {
double designAdsorptionTemperature = 298.0;
double designRegenerationTemperature = 440.0;
double designAdsorptionPressure = 60.0;
int numberOfAdorptionBeds = 3;
int numberOfAdsorptionBeds = 3;
double adsorberInternalDiameter = 1.0;
double adsorbentFillingHeight = 3.0;

Expand Down Expand Up @@ -103,8 +103,8 @@ public void run(UUID id) {
public void initializeStreams() {
isInitializedStreams = true;
try {
adsorber = new SimpleAdsorber[numberOfAdorptionBeds];
for (int i = 0; i < numberOfAdorptionBeds; i++) {
adsorber = new SimpleAdsorber[numberOfAdsorptionBeds];
for (int i = 0; i < numberOfAdsorptionBeds; i++) {
adsorber[i] = new SimpleAdsorber("SimpleAdsorber_" + i + 1, gasStreamToAdsorber);
}
this.gasStreamFromAdsorber = (Stream) this.gasStreamToAdsorber.clone();
Expand Down Expand Up @@ -159,7 +159,7 @@ public void calcDesign() {

double gasVelocity = 67.0 / Math.sqrt(gasDensity);

double qa = designFlow / (numberOfAdorptionBeds - 1.0) / 1440.0
double qa = designFlow / (numberOfAdsorptionBeds - 1.0) / 1440.0
* (1.01325 / designAdsorptionPressure) * (designAdsorptionTemperature / 288.15)
* tempStream.getThermoSystem().getPhase(0).getZ();
adsorberInternalDiameter = Math.sqrt(4.0 * qa / Math.PI / gasVelocity);
Expand All @@ -185,7 +185,7 @@ public void calcDesign() {
/** {@inheritDoc} */
@Override
public void setDesign() {
for (int i = 0; i < numberOfAdorptionBeds; i++) {
for (int i = 0; i < numberOfAdsorptionBeds; i++) {
adsorber[i].getMechanicalDesign().setInnerDiameter(adsorberInternalDiameter);
adsorber[i].getMechanicalDesign().setTantanLength(adsorbentFillingHeight * 1.5);
}
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/neqsim/thermo/component/Component.java
Original file line number Diff line number Diff line change
Expand Up @@ -612,7 +612,7 @@ public double getHeatOfVapourization(double temp) {

/** {@inheritDoc} */
@Override
public final double getTripplePointDensity() {
public final double getTriplePointDensity() {
return triplePointDensity;
}

Expand Down
Loading