Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added getUnit and copy methods to ProcessModule #678

Merged
merged 2 commits into from
May 11, 2023

Conversation

Sviatose
Copy link
Collaborator

@Sviatose Sviatose commented May 10, 2023

This pull request adds the getUnit and copy methods to the ProcessModule class. The getUnit method allows the user to retrieve a unit with a given name from the list of added unit operations and a list of added modules, while the copy method creates a deep copy of the ProcessModule instance.

@Sviatose Sviatose requested a review from EvenSol as a code owner May 10, 2023 15:35
Copy link
Collaborator

@EvenSol EvenSol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update👍

@EvenSol EvenSol merged commit fca5eb7 into master May 11, 2023
@EvenSol EvenSol deleted the feat--Add-getUnit-and-Copy-methods-Modules branch May 11, 2023 06:28
asmfstatoil added a commit to asmfstatoil/neqsim that referenced this pull request May 19, 2023
* feat: added getUnit, copy methods to modules

* style

---------

Co-authored-by: Åsmund Våge Fannemel <34712686+asmfstatoil@users.noreply.github.com>
EvenSol pushed a commit that referenced this pull request May 22, 2023
* feat: added getUnit, copy methods to modules

* style

---------

Co-authored-by: Åsmund Våge Fannemel <34712686+asmfstatoil@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants