-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ColorMapFunction type in WellLogView #2249
Conversation
typescript/packages/well-log-viewer/src/WellLogViewer.stories.tsx
Outdated
Show resolved
Hide resolved
Does it make sense to specify both color function array AND color table array ? |
@w1nklr Color table array could be easily read/written from/to a JSON file. If both color table and color function are referenced in a template then color table is used. If we want to have the only reference for both color sources then we should mix color tables and color functions in a one array of inhomogeneous elements. |
OK. I won't fight to get one single prop to handle both the tables and the function (even if I think it's not a good API). |
@w1nklr, I like your idea to combine color tables and color functions. Because it simplify code.
|
Let's use colorFunc, that can be a color function or a color table. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a breaking API change, suggest using the "feat!" prefix in the title and a "BREAKING CHANGE: [describe what is breaking]" in the description.
typescript/packages/well-log-viewer/src/SyncLogViewer.stories.tsx
Outdated
Show resolved
Hide resolved
Looks like there is a prettier formatting issue in the python wrapper code. |
typescript/packages/well-log-viewer/src/components/ColorTableTypes.ts
Outdated
Show resolved
Hide resolved
typescript/packages/well-log-viewer/src/components/ColorTableTypes.ts
Outdated
Show resolved
Hide resolved
typescript/packages/well-log-viewer/src/components/ScaleSelector.stories.tsx
Outdated
Show resolved
Hide resolved
typescript/packages/well-log-viewer/src/components/WellLogView.tsx
Outdated
Show resolved
Hide resolved
typescript/packages/well-log-viewer/src/components/ZoomSlider.stories.tsx
Outdated
Show resolved
Hide resolved
typescript/packages/well-log-viewer/src/utils/gradientfill-plot-legend.ts
Show resolved
Hide resolved
typescript/packages/well-log-viewer/src/components/ColorMapFunction.ts
Outdated
Show resolved
Hide resolved
typescript/packages/well-log-viewer/src/components/WellLogView.tsx
Outdated
Show resolved
Hide resolved
# [1.0.0](https://github.com/equinor/webviz-subsurface-components/compare/wsc-common@0.8.9...wsc-common@1.0.0) (2024-10-03) ### Features * ColorMapFunction type in WellLogView ([#2249](#2249)) ([96bcab4](96bcab4)), closes [#2054](#2054) [#2259](#2259) ### BREAKING CHANGES * - colorMapFunctions array replaces colorTables array to combine color tables and functions in single array - colorMapFunctionName and reverseColorMapFunctionName references replace colorTable and reverseColorTable references (JSON files also should be changed)
🎉 This issue has been resolved in version wsc-common@1.0.0 🎉 The release is available on GitHub release |
# [1.0.0](https://github.com/equinor/webviz-subsurface-components/compare/subsurface-viewer@0.30.17...subsurface-viewer@1.0.0) (2024-10-03) ### Features * ColorMapFunction type in WellLogView ([#2249](#2249)) ([96bcab4](96bcab4)), closes [#2054](#2054) [#2259](#2259) ### BREAKING CHANGES * - colorMapFunctions array replaces colorTables array to combine color tables and functions in single array - colorMapFunctionName and reverseColorMapFunctionName references replace colorTable and reverseColorTable references (JSON files also should be changed)
🎉 This issue has been resolved in version subsurface-viewer@1.0.0 🎉 The release is available on GitHub release |
# [2.0.0](https://github.com/equinor/webviz-subsurface-components/compare/well-log-viewer@1.13.11...well-log-viewer@2.0.0) (2024-10-03) ### Features * ColorMapFunction type in WellLogView ([#2249](#2249)) ([96bcab4](96bcab4)), closes [#2054](#2054) [#2259](#2259) ### BREAKING CHANGES * - colorMapFunctions array replaces colorTables array to combine color tables and functions in single array - colorMapFunctionName and reverseColorMapFunctionName references replace colorTable and reverseColorTable references (JSON files also should be changed)
🎉 This issue has been resolved in version well-log-viewer@2.0.0 🎉 The release is available on GitHub release |
BREAKING CHANGE: