Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: color of undefined value for 3D grids is incorrect #2253

Merged
merged 5 commits into from
Sep 23, 2024

Conversation

w1nklr
Copy link
Collaborator

@w1nklr w1nklr commented Sep 20, 2024

The color was way to clear, and was missing the 0-255 to 0-1 conversion.

The color was way to clear, and was missing the 0=255 to 0-1 conversion.
@w1nklr w1nklr requested a review from hkfb September 20, 2024 12:58
@w1nklr w1nklr removed the request for review from hkfb September 20, 2024 15:01
@w1nklr w1nklr merged commit d53b213 into equinor:master Sep 23, 2024
10 checks passed
@w1nklr w1nklr deleted the fix_ndv_color branch September 23, 2024 07:38
hkfb pushed a commit that referenced this pull request Sep 23, 2024
@hkfb
Copy link
Collaborator

hkfb commented Sep 23, 2024

🎉 This issue has been resolved in version subsurface-viewer@0.30.10 🎉

The release is available on GitHub release

@hkfb hkfb added the released label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants