Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W3 valid demo with fallback to html input elements #32

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kmturley
Copy link

In reference to this issue:
#31

Allowed use of html inputs so it can pass w3 validation:

<label for="tags">Tags</label>
<input id="tags" type="text" placeholder="Enter tags (separated by commas)" class="js-tag" />

@eranhirs
Copy link
Owner

eranhirs commented Jan 9, 2016

Thank you for your contribution

  • Please remove index.html (if you want to change it you need to compare against the 'gh-pages' branch)
  • Please update the version in package.json & bower.json to 0.3.8

@eranhirs
Copy link
Owner

eranhirs commented Jan 9, 2016

Please remove replace: true since it might break existing applications.
Plus, it's normal to have a custom tag in Web Components & replace is deprecated
See this stackoverflow question regarding replace: 'true' for more information

@kmturley
Copy link
Author

An update:

  • remove index.html, shouldn't there be a demo somewhere in the repo of how to use? not just on gh-pages?
  • update the version, done
  • remove replace: true, it won't really work without replace, as the original element is an input. This gets replaced by the custom input. The only way it could work is to have a wrapper around every input with the js-tag class. Not a great solution. Replace:true is much cleaner and seems to be supported still?
  • in addition i've add a hidden input contained the final result of all tags inputted:

    This is useful for normal form POST functions which need the tags in an html format

@eranhirs
Copy link
Owner

eranhirs commented Mar 5, 2016

  • I don't see why we need index.html inside the master branch
  • I stand by my opinion about replace: true , it sounds to me like the W3 validator is outdated.

" ng-blur=\"inputService.onBlur(tagsCollection)\"\n" +
" placeholder=\"{{options.texts.inputPlaceHolder}}\"\n" +
" auto-grow\n" +
" options=\"exampleOptions\" datasets=\"exampleData\"\n" +

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be sampleData? not exampleData

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants