-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add requirements for IAccountExecute #180
Conversation
Could you expand a bit on why we want to loosen this? And also, I remember we previously discussed how validation-associated exec hooks could be done without |
Oh hmm. Do we absolutely need accounts to implement |
Discussed async, summary:
|
@@ -540,7 +540,7 @@ If the selector being checked is `execute` or `executeBatch`, the modular accoun | |||
|
|||
Installed validations have two flag variables indicating what they may be used for. If a validation is attempted to be used for user op validation and the flag `isUserOpValidation` is set to false, validation MUST revert. If the validation is attempted to be used for signature validation and the flag `isSignatureValidation` is set to false, validation MUST revert. | |||
|
|||
#### Direct Call Validation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix - other titles do not contain periods at the end
2ecdb6c
to
57e4656
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, two small nits
99a887f
to
eb1b63d
Compare
No description provided.