-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: v0.8 review and polish #186
Conversation
c2b2c5d
to
2eccf6a
Compare
Summary by OctaneNew ContractsNo new contracts were added in this PR. Updated Contracts
🔗 Commit Hash: 2cc57dd |
OverviewOctane AI analysis has finished. No vulnerabilities were found. Cheers! 🎉🎉🎉 🔗 Commit Hash: 2cc57dd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for the thorough review!
Some updates to the spec after a review. This PR does not make any changes that would result in interface selectors changing. Will follow up on another PR for one change that would impact that for a more careful review.
Notable changes (non-exhaustive):
Modular Smart Contract Accounts and Modules
toModular Smart Contract Accounts
. I think the latter implies that the standard would cover modules. Feel free to push back on this.The account MUST remove all supported interfaces as specified in the manifest.
toThe account SHOULD remove all supported interfaces as specified in the manifest.
This allows account implementations to choose custom behavior such as how to handle duplicate interface IDs.