Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust msp router & add member manage & add notify-group manage #1046

Merged
merged 4 commits into from
Sep 6, 2021

Conversation

Zero-Rock
Copy link
Contributor

@Zero-Rock Zero-Rock commented Sep 1, 2021

What this PR does / why we need it:

adjust msp router,
add member manage
add notify-group manage
relate PR#66

Does this PR introduce a user interface change?

❎ No

ChangeLog

Language Changelog
🇺🇸 English adjust msp router, add member manage, add notify-group manage
🇨🇳 中文 微服务平台菜单调整,微服务项目成员管理,通知组管理

Does this PR need be patched to older version?

❎ No

Which issue(s) this PR fixes:

Fixes #

@Zero-Rock Zero-Rock changed the title msp adjust msp router & add member manage & add notify-group manage Sep 1, 2021
@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #1046 (9c457b3) into master (71c9c4c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1046      +/-   ##
==========================================
+ Coverage   82.82%   82.84%   +0.01%     
==========================================
  Files         115      115              
  Lines        7098     7104       +6     
  Branches     1964     1965       +1     
==========================================
+ Hits         5879     5885       +6     
  Misses       1182     1182              
  Partials       37       37              
Impacted Files Coverage Δ
shell/app/common/components/add-member-modal.tsx 98.33% <100.00%> (+0.02%) ⬆️
...l/app/common/components/authorize-member-modal.tsx 95.74% <100.00%> (+0.09%) ⬆️
shell/app/common/components/member-selector.tsx 94.91% <100.00%> (+0.02%) ⬆️
shell/app/common/components/members-table.tsx 91.15% <100.00%> (+0.07%) ⬆️
shell/app/common/utils/go-to.tsx 94.89% <100.00%> (+0.02%) ⬆️

@Zero-Rock Zero-Rock added feature new feature msp Microservice platform labels Sep 1, 2021
@Zero-Rock Zero-Rock force-pushed the feature/msp-member branch 2 times, most recently from 815b6bc to d92c4b1 Compare September 3, 2021 13:42
@Zero-Rock Zero-Rock marked this pull request as ready for review September 3, 2021 13:49
feat(msp): remove service analysis
fix(msp): mamber manage

fix(msp): remove mock

fix(msp): remove cconsole
@daskyrk
Copy link
Contributor

daskyrk commented Sep 6, 2021

/approve

@erda-bot erda-bot added the approved Auto tagged by robot label Sep 6, 2021
@erda-bot erda-bot merged commit 9c7eaee into erda-project:master Sep 6, 2021
@Zero-Rock Zero-Rock deleted the feature/msp-member branch September 8, 2021 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Auto tagged by robot feature new feature msp Microservice platform
Development

Successfully merging this pull request may close these issues.

3 participants